Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: generate_test_report.py

Issue 6534006: Add crash whitelist for chromeos-wm: sig 6. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: generate_test_report.py
diff --git a/generate_test_report.py b/generate_test_report.py
index 33ec0a6ead47abea8982e9045b1dd0d7d9d3a1af..d21ea5286d28b3072ca96c6a35aaaa3f23409356 100755
--- a/generate_test_report.py
+++ b/generate_test_report.py
@@ -22,6 +22,13 @@ from cros_build_lib import Color, Die
_STDOUT_IS_TTY = hasattr(sys.stdout, 'isatty') and sys.stdout.isatty()
+# List of crashes which are okay to ignore. This list should almost always be
+# empty. If you add an entry, mark it with a TODO(<your name>) and the issue
+# filed for the crash.
+_CRASH_WHITELIST = {
+ # TODO(dalecurtis): chromium-os:12212. Remove when resolved.
+ 'chromeos-wm': ['sig 6']
+}
class ReportGenerator(object):
"""Collects and displays data from autoserv results directories.
@@ -116,6 +123,9 @@ class ReportGenerator(object):
crashes = []
regex = re.compile('Received crash notification for ([-\w]+).+ (sig \d+)')
for match in regex.finditer(status_raw):
+ if (match.group(1) in _CRASH_WHITELIST and
+ match.group(2) in _CRASH_WHITELIST[match.group(1)]):
+ continue
crashes.append('%s %s' % match.groups())
self._results[testdir] = {'crashes': crashes,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698