Add sync_integration_tests support to valgrind's chrome_tests.sh.

Add sync_integration_tests support to valgrind's chrome_tests.sh.

BUG=73198
TEST=self

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75322

[Nicolas Zea, 2011-02-16 22:13:37]

Mind taking a look?

[Timur Iskhodzhanov, 2011-02-17 10:37:01]

http://codereview.chromium.org/6534004/diff/1/tools/valgrind/chrome_tests.py
File tools/valgrind/chrome_tests.py (right):

http://codereview.chromium.org/6534004/diff/1/tools/valgrind/chrome_tests.py#...
tools/valgrind/chrome_tests.py:311: return self.SimpleTest("chrome",
"sync_integration_tests")
What are sync_integration_tests?

Do they spawn Chrome processes?

http://codereview.chromium.org/6534004/diff/1/tools/valgrind/chrome_tests.py#...
tools/valgrind/chrome_tests.py:434: "sync_integration_tests":
TestSyncIntegration,
You may also add
"sync_integration": TestSyncIntegration,

That'd be useful when setting up a valgrind bot because otherwise you'll need to
name a test run target as
vagrlind_sync_integration_tests
:)

[Timur Iskhodzhanov, 2011-02-17 10:39:13]

http://codereview.chromium.org/6534004/diff/1/tools/valgrind/chrome_tests.py
File tools/valgrind/chrome_tests.py (right):

http://codereview.chromium.org/6534004/diff/1/tools/valgrind/chrome_tests.py#...
tools/valgrind/chrome_tests.py:311: return self.SimpleTest("chrome",
"sync_integration_tests")
Self-answer: yes, they do.

In this case, you should better copy the TestSafeBrowsing or TestInteractiveUI
instead of TestSync.

On 2011/02/17 10:37:02, Timur Iskhodzhanov wrote:
> What are sync_integration_tests?
> 
> Do they spawn Chrome processes?

[Timur Iskhodzhanov, 2011-02-17 14:54:33]

I've just run sync_integration_tests locally with Valgrind and it took 4 hours
on Z600.
Is this expected?
Did you plan to run these tests on the memory waterfall?

[Nicolas Zea, 2011-02-17 21:07:51]

Please take another look.

Not planning on putting it on the waterfall at the moment. Yeah, the individual
tests on their own can take as much as ~15-20s, and there's quite a few, so I'm
not surprised running the full suite under valgrind reached that long. But, it
should still be useful on a test by test basis when debugging.

http://codereview.chromium.org/6534004/diff/1/tools/valgrind/chrome_tests.py
File tools/valgrind/chrome_tests.py (right):

http://codereview.chromium.org/6534004/diff/1/tools/valgrind/chrome_tests.py#...
tools/valgrind/chrome_tests.py:311: return self.SimpleTest("chrome",
"sync_integration_tests")
On 2011/02/17 10:39:13, Timur Iskhodzhanov wrote:
> Self-answer: yes, they do.
> 
> In this case, you should better copy the TestSafeBrowsing or TestInteractiveUI
> instead of TestSync.
> 
> On 2011/02/17 10:37:02, Timur Iskhodzhanov wrote:
> > What are sync_integration_tests?
> > 
> > Do they spawn Chrome processes?
> 

Done.

http://codereview.chromium.org/6534004/diff/1/tools/valgrind/chrome_tests.py#...
tools/valgrind/chrome_tests.py:434: "sync_integration_tests":
TestSyncIntegration,
On 2011/02/17 10:37:02, Timur Iskhodzhanov wrote:
> You may also add
> "sync_integration": TestSyncIntegration,
> 
> That'd be useful when setting up a valgrind bot because otherwise you'll need
to
> name a test run target as
> vagrlind_sync_integration_tests
> :)

Done.

[Timur Iskhodzhanov, 2011-02-17 21:11:31]

LGTM

I'm happy you run these tests locally :)
Feel free to ping me if you do find it useful for setting up a bot for that
(maybe on a subset of tests?)