Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 6534003: set_shared_user_password.sh updates /etc/shared_user_passwd.txt (Closed)

Created:
9 years, 10 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
davidjames
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

set_shared_user_password.sh updates /etc/shared_user_passwd.txt This is necessary so that the baselayout ebuild can be changed to set /etc/passwd and /etc/shadow appropriately. A previous attempt to do this through an environment variable in make.conf.user failed because pkg_postinst from binary packages run in their prebuilt environment (and, thus, are not picking the user specific variables). BUG=chromium-os:11664 TEST=ran set_shared_user_password.sh multiple times, observed /etc/shared_user_passwd.txt and shared_user_passwd.txt getting updated. Change-Id: I23b77c7417db0fd18b251f7cca62027813b182a8 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=36e69d0

Patch Set 1 #

Patch Set 2 : move set_make_conf_user_var from common.sh #

Patch Set 3 : switch to a file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M set_shared_user_password.sh View 1 2 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
petkov
9 years, 10 months ago (2011-02-16 21:34:06 UTC) #1
davidjames
LGTM
9 years, 10 months ago (2011-02-16 22:55:06 UTC) #2
petkov
PTAL
9 years, 10 months ago (2011-02-16 23:10:47 UTC) #3
davidjames
LGTM
9 years, 10 months ago (2011-02-16 23:12:28 UTC) #4
petkov
PTAL. Updated description too.
9 years, 10 months ago (2011-02-17 00:56:29 UTC) #5
davidjames
9 years, 10 months ago (2011-02-17 01:03:18 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698