Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 6533013: Move ui::gfx::Image out of the ui namespace to be just gfx::Image. (Closed)

Created:
9 years, 10 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move ui::gfx::Image out of the ui namespace to be just gfx::Image. Having namespaces ui::gfx and just gfx are causing compiler disambiguation problems. This will resolve that. BUG=carnitas TEST=compiles and gfx_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -27 lines) Patch
M chrome/browser/ui/tests/ui_gfx_image_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/tests/ui_gfx_image_unittest.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/image.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/gfx/image.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M ui/gfx/image_mac.mm View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/gfx/image_unittest.h View 3 chunks +1 line, -3 lines 0 comments Download
M ui/gfx/image_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
9 years, 10 months ago (2011-02-16 23:47:22 UTC) #1
Mark Mentovai
Isn’t this contrary to the new namespacing policy? Where is this causing trouble? Would fully ...
9 years, 10 months ago (2011-02-17 00:38:26 UTC) #2
Robert Sesek
On Wed, Feb 16, 2011 at 7:38 PM, <mark@chromium.org> wrote: > Isn’t this contrary to ...
9 years, 10 months ago (2011-02-17 01:26:47 UTC) #3
Mark Mentovai
9 years, 10 months ago (2011-02-17 17:20:36 UTC) #4
OK, looks good.

Powered by Google App Engine
This is Rietveld 408576698