Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 6533012: Write images to the bmpblock in the order they appear in the yaml. (Closed)

Created:
9 years, 10 months ago by Bill Richardson
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Write images to the bmpblock in the order they appear in the yaml. This ensures that equivalent yaml files produce identical bmpblock binaries. BUG=chromium-os:12158 TEST=manual cd src/platform/vboot_reference make make runbmptests Change-Id: Ic8103ff90e57034d72fb3920a6c198c77768f162 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f82f941

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -5 lines) Patch
M tests/bitmaps/TestBmpBlock.py View 1 chunk +20 lines, -0 lines 0 comments Download
A tests/bitmaps/case_order1.yaml View 1 chunk +36 lines, -0 lines 0 comments Download
A tests/bitmaps/case_order2.yaml View 1 chunk +36 lines, -0 lines 0 comments Download
M utility/bmpblk_utility.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M utility/include/bmpblk_utility.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Richardson
9 years, 10 months ago (2011-02-16 23:15:30 UTC) #1
Tom Wai-Hong Tam
LGTM
9 years, 10 months ago (2011-02-17 02:31:38 UTC) #2
Randall Spangler
9 years, 10 months ago (2011-02-17 17:22:47 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698