Issue 6533012: Write images to the bmpblock in the order they appear in the yaml.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6533012: Write images to the bmpblock in the order they appear in the yaml. (Closed)

Created:
9 years, 10 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler, Tom Wai-Hong Tam

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://git.chromium.org/git/vboot_reference.git@master

Visibility:
Public.

Description

Write images to the bmpblock in the order they appear in the yaml. This ensures that equivalent yaml files produce identical bmpblock binaries. BUG=chromium-os:12158 TEST=manual cd src/platform/vboot_reference make make runbmptests Change-Id: Ic8103ff90e57034d72fb3920a6c198c77768f162 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f82f941

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -5 lines)			Patch
M	tests/bitmaps/TestBmpBlock.py	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	tests/bitmaps/case_order1.yaml	View	1 chunk	+36 lines, -0 lines	0 comments	Download
A	tests/bitmaps/case_order2.yaml	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	utility/bmpblk_utility.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	utility/include/bmpblk_utility.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages