chrome/installer/setup/install_worker.cc - Issue 6533009: Switch from wcsftime to GetDateFormat to avoid crash in setup....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install_worker.cc

Issue 6533009: Switch from wcsftime to GetDateFormat to avoid crash in setup.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/installer/setup/install_worker.cc

===================================================================

--- chrome/installer/setup/install_worker.cc (revision 74952)

+++ chrome/installer/setup/install_worker.cc (working copy)

@@ -220,15 +220,10 @@

L"DisplayVersion",

UTF8ToWide(new_version.GetString()),

true);

- time_t rawtime = time(NULL);

- struct tm timeinfo = {0};

- localtime_s(&timeinfo, &rawtime);

- wchar_t buffer[9];

- if (wcsftime(buffer, 9, L"%Y%m%d", &timeinfo) == 8) {

- install_list->AddSetRegValueWorkItem(reg_root, uninstall_reg,

- L"InstallDate",

- buffer, false);

- }

+ install_list->AddSetRegValueWorkItem(reg_root, uninstall_reg,

+ L"InstallDate",

+ InstallUtil::GetCurrentDate(),

+ false);

}