Switch from wcsftime to GetDateFormat to avoid crash in setup....

chrome/installer/util/install_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // See the corresponding header file for description of the functions in this
 // file.
 
 #include "chrome/installer/util/install_util.h"
 
 #include <shellapi.h>
@@ skipping 245 matching lines @@
     std::wstring command;
     command.append(1, L'"')
         .append(no_program ? L"" : exe_path)
         .append(L"\" ")
         .append(arguments);
 
     // If we have a program name, return this complete command line.
     *command_line = CommandLine::FromString(command);
   }
 }
+
+std::wstring InstallUtil::GetCurrentDate() {
+  wchar_t date_str[10] = {0};

[grt (UTC plus 2), 2011/02/17 04:04:10]

Why 10?

[tommi (sloooow) - chröme, 2011/02/17 19:40:09]

nervousness around yyyyy

+  const wchar_t kDateFormat[] = L"yyyyMMdd";

[grt (UTC plus 2), 2011/02/17 04:04:10]

nit: static const?

[tommi (sloooow) - chröme, 2011/02/17 19:40:09]

Done.

+  size_t ret = GetDateFormatW(LOCALE_USER_DEFAULT, 0, NULL, kDateFormat,

[grt (UTC plus 2), 2011/02/17 04:04:10]

Use LOCALE_INVARIANT.  Otherwise, you could potentially write something like
43440216 into the registry (this is year 4344 in the/a Korean calendar), which
isn't what the "Programs and Features" control panel expects.  It expects
Gregorian in the registry, which it appears to parse then format according to
the user's display region.

[grt (UTC plus 2), 2011/02/17 04:04:10]

MSDN says GetDateFormat returns an int.  If you chose size_t for the sake of the
DCHECK, consider switching to int if you take my advice below.

[tommi (sloooow) - chröme, 2011/02/17 19:40:09]

Done.

+                              date_str, arraysize(date_str));
+  DCHECK_EQ(arraysize(kDateFormat), ret);

[grt (UTC plus 2), 2011/02/17 04:04:10]

MSDN says that 'yyyy' can yield a 5-digit year, which would cause this DCHECK to
fail.  Given the LOCAL_INVARIANT comment above, that shouldn't happen until
Y10k.  In either case, I don't see that this DCHECK is helpful.  How about
instead DPLOG_IF(DFATAL, ret == 0) so that we see the last-error code in logs?

[tommi (sloooow) - chröme, 2011/02/17 19:40:09]

Done.

+  return date_str;

[grt (UTC plus 2), 2011/02/17 04:04:10]

I'm a huge fan of std::wstring(date_str, ret), which avoids a needless strlen
since you know the length.

[tommi (sloooow) - chröme, 2011/02/17 19:40:09]

Done.

+}