Issue 6532102: Fix style mistakes in r75477.

Issue 6532102: Fix style mistakes in r75477. (Closed)

Created:
9 years, 10 months ago by awong

Modified:
9 years, 7 months ago

Reviewers:
dmac, sadrul, Evan Martin

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, brettw-cc_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix style mistakes in r75477. Associated review at: http://codereview.chromium.org/6489031/ BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76074

Patch Set 1 #

Patch Set 2 : real diff #

Patch Set 3 : spelling #

Total comments: 6

Patch Set 4 : USE_X11 #

Patch Set 5 : rebased #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -11 lines)			Patch
M	base/message_loop.h	View	1 2 3	2 chunks	+14 lines, -6 lines	0 comments	Download
M	base/message_loop.cc	View	1 2 3	1 chunk	+3 lines, -4 lines	0 comments	Download
M	remoting/host/event_executor_linux.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dmac

Since you are here, some minor nits. http://codereview.chromium.org/6532102/diff/5001/base/message_loop.cc File base/message_loop.cc (right): http://codereview.chromium.org/6532102/diff/5001/base/message_loop.cc#newcode672 base/message_loop.cc:672: #if defined(OS_POSIX) ...

9 years, 10 months ago (2011-02-23 04:57:21 UTC) #2

sadrul

Using USE_X11 sounds like a good idea. Other than that, LGTM.

9 years, 10 months ago (2011-02-23 13:09:43 UTC) #3

awong

9 years, 10 months ago (2011-02-24 03:43:37 UTC) #4

done.  running through try-bots and will submit if no other comments.

http://codereview.chromium.org/6532102/diff/5001/base/message_loop.cc
File base/message_loop.cc (right):

http://codereview.chromium.org/6532102/diff/5001/base/message_loop.cc#newcode672
base/message_loop.cc:672: #if defined(OS_POSIX) && !defined(OS_MACOSX)
On 2011/02/23 04:57:22, dmac wrote:
> should this be #if defined(USE_X11)

Done.

http://codereview.chromium.org/6532102/diff/5001/base/message_loop.h
File base/message_loop.h (right):

http://codereview.chromium.org/6532102/diff/5001/base/message_loop.h#newcode512
base/message_loop.h:512: #if defined(OS_POSIX) && !defined(OS_MACOSX)
On 2011/02/23 04:57:22, dmac wrote:
> should this be #if defined(USE_X11)?

Done.

http://codereview.chromium.org/6532102/diff/5001/base/message_loop.h#newcode522
base/message_loop.h:522: #endif
On 2011/02/23 04:57:22, dmac wrote:
> Can you mark this #endif with // whatever?

Done.

Expand Messages | Collapse Messages