Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 6532088: Partial refactoring of subgraphs. (Closed)

Created:
9 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Partial refactoring of subgraphs. Change the interface to the Hydrogen graph builder to appear like it directly holds a current basic block and a current environment. Remove some direct accesses to the current subgraph, and remove subgraph accessors that simply forwarded to the exit block. Committed: http://code.google.com/p/v8/source/detail?r=6887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -88 lines) Patch
M src/hydrogen.h View 3 chunks +11 lines, -18 lines 0 comments Download
M src/hydrogen.cc View 40 chunks +89 lines, -70 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
Context for this change: I'm trying to get rid of class HSubgraph, the extra indirection ...
9 years, 10 months ago (2011-02-22 10:20:16 UTC) #1
fschneider
9 years, 10 months ago (2011-02-22 10:29:00 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698