src/v8natives.js - Issue 6532087: Expand fast case of parseInt to include radix == 10 and radix == 0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8natives.js

Issue 6532087: Expand fast case of parseInt to include radix == 10 and radix == 0. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/v8natives.js

===================================================================

--- src/v8natives.js (revision 6877)

+++ src/v8natives.js (working copy)

@@ -92,7 +92,7 @@

// ECMA-262 - 15.1.2.2

function GlobalParseInt(string, radix) {

- if (IS_UNDEFINED(radix)) {

+ if (IS_UNDEFINED(radix) || radix == 10 || radix == 0) {

Erik Corry 2011/02/22 08:53:05 I think you want === here.

Mads Ager (chromium) 2011/02/22 08:53:55 Erik suggests using === here. I agree with that an

sandholm 2011/02/22 08:59:57 Done.

// Some people use parseInt instead of Math.floor. This

// optimization makes parseInt on a Smi 12 times faster (60ns

// vs 800ns). The following optimization makes parseInt on a

« no previous file with comments | « no previous file | no next file » | no next file with comments »