Issue 6532087: Expand fast case of parseInt to include radix == 10 and radix == 0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6532087: Expand fast case of parseInt to include radix == 10 and radix == 0. (Closed)

Created:
9 years, 10 months ago by sandholm

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Expand fast case of parseInt to include radix == 10 and radix == 0.

Patch Set 2 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/v8natives.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

http://codereview.chromium.org/6532087/diff/1/src/v8natives.js File src/v8natives.js (right): http://codereview.chromium.org/6532087/diff/1/src/v8natives.js#newcode95 src/v8natives.js:95: if (IS_UNDEFINED(radix) || radix == 10 || radix == ...

9 years, 10 months ago (2011-02-22 08:53:05 UTC) #2

Mads Ager (chromium)

LGTM http://codereview.chromium.org/6532087/diff/1/src/v8natives.js File src/v8natives.js (right): http://codereview.chromium.org/6532087/diff/1/src/v8natives.js#newcode95 src/v8natives.js:95: if (IS_UNDEFINED(radix) || radix == 10 || radix ...

9 years, 10 months ago (2011-02-22 08:53:55 UTC) #3

sandholm

9 years, 10 months ago (2011-02-22 08:59:57 UTC) #4

OK. I get the point :-)

http://codereview.chromium.org/6532087/diff/1/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/6532087/diff/1/src/v8natives.js#newcode95
src/v8natives.js:95: if (IS_UNDEFINED(radix) || radix == 10 || radix == 0) {
On 2011/02/22 08:53:05, Erik Corry wrote:
> I think you want === here.

Done.

http://codereview.chromium.org/6532087/diff/1/src/v8natives.js#newcode95
src/v8natives.js:95: if (IS_UNDEFINED(radix) || radix == 10 || radix == 0) {
On 2011/02/22 08:53:55, Mads Ager wrote:
> Erik suggests using === here. I agree with that and we should do so below as
> well (the checks before %_GetCachedArrayIndex).

Done.

Expand Messages | Collapse Messages

Issue 6532087: Expand fast case of parseInt to include radix == 10 and radix == 0. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages