Issue 6532051: Fix heap profiler to always append the process id to the heap dump....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6532051: Fix heap profiler to always append the process id to the heap dump.... (Closed)

Created:
9 years, 10 months ago by Alexander Potapenko

Modified:
9 years, 6 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix heap profiler to always append the process id to the heap dump. To run Chrome: HEAP_PROFILE_ALLOCATION_INTERVAL=1000000 HEAPPROFILE=heapprof out/Debug/chrome To analyze: pprof --text out/Debug/chrome heapprof.21026.0039.heap pprof --gv out/Debug/chrome heapprof.21026.0039.heap (pprof is slooow) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86273

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	third_party/tcmalloc/chromium/src/base/sysinfo.cc	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
	M	third_party/tcmalloc/chromium/src/heap-profiler.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

LGTM http://codereview.chromium.org/6532051/diff/4001/third_party/tcmalloc/chromium/src/base/sysinfo.cc File third_party/tcmalloc/chromium/src/base/sysinfo.cc (right): http://codereview.chromium.org/6532051/diff/4001/third_party/tcmalloc/chromium/src/base/sysinfo.cc#newcode192 third_party/tcmalloc/chromium/src/base/sysinfo.cc:192: envval[0] |= 128; // set high bit for ...

9 years, 7 months ago (2011-05-20 21:26:06 UTC) #2

Alexander Potapenko

9 years, 7 months ago (2011-05-23 09:45:01 UTC) #3

Fixed and committed.

http://codereview.chromium.org/6532051/diff/4001/third_party/tcmalloc/chromiu...
File third_party/tcmalloc/chromium/src/base/sysinfo.cc (right):

http://codereview.chromium.org/6532051/diff/4001/third_party/tcmalloc/chromiu...
third_party/tcmalloc/chromium/src/base/sysinfo.cc:192: envval[0] |= 128;        
            // set high bit for kids to seed
On 2011/05/20 21:26:06, willchan wrote:
> seed? is that a typo?

Done.

Expand Messages | Collapse Messages