Make chromoting connect always work

remoting/client/extension/background.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * If there is already a tab with the given URL, switch focus to it. Otherwise,
  * create a new tab and open the URL.
  *
  * @param url The URL to open.
  */
@@ skipping 45 matching lines @@
     xmppAuth: getCookie('xmpp_auth'),
     hostName: hostName,
     hostJid: hostJid,
   };
 
   console.log("Attempt to connect with" +
               " username='" + request.username + "'" +
               " hostName='" + request.hostName + "'" +
               " hostJid='" + request.hostJid + "'" +
               " auth_token='" + request.xmppAuth + "'");
-  navigate(newTabUrl, function(tab) {
-      console.log("We're trying now to send to " + tab.id);
-      chrome.tabs.sendRequest(
-          tab.id, request, function() {
-            console.log('Tab finished connect.');
-          });
-    });
+
+  var sendRequestFunc = function (tab) {
+    console.log("We're trying now to send to " + tab.id);

[awong, 2011/02/18 00:31:01]

At some point, I'm wondering if we should have a custom "log" function that
inspects a variable which can be toggled at runtime.

[Alpha Left Google, 2011/02/18 00:44:06]

hm.. i was thinking about this too, but since we don't connect a lot we won't be
writing a lot of of messages so it's ok.

+    chrome.tabs.sendRequest(
+        tab.id, request, function() {
+          console.log('Tab finished connect.');
+        });
+  };
+
+  var checkStatusFunc = function (tab) {
+    if (tab.status == "complete") {
+      sendRequestFunc(tab);
+      return;
+    }
+
+    // Wait for 500ms and then get the tab and check its status.

[awong, 2011/02/18 00:31:01]

Is there no way to have a signal on tab status change?  a 500ms loop is fine as
a stop-gap, but it's guarantees a 500ms latency in the UI.

[Alpha Left Google, 2011/02/18 00:44:06]

there's only two ways, pass arguments as url into chromoting_tab.js, or inspect
the tab status..

There's is a 500ms latency only if the first trial failed, we can shorten the
timeout though.

+    setTimeout(function() {
+        chrome.tabs.get(tab.id, checkStatusFunc);
+      }, 500);
+  }
+
+  navigate(newTabUrl, checkStatusFunc);
 }