Issue 6532033: Disable "Reset to Default theme"/"Use classic theme" correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6532033: Disable "Reset to Default theme"/"Use classic theme" correctly. (Closed)

Created:
9 years, 10 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Miranda Callahan, Evan Stade

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Disable "Reset to Default theme"/"Use classic theme" correctly. The theme on the gallery that corresponds to classic has a real extension id that we need to detect. By the time the BrowserThemeProvider can detect it, it has already been unpacked so just hard code the extension ID into chrome. BUG=67751 TEST=Install a theme, verify that 'use classic theme' is enabled, install Default theme, verify that 'use classic theme' is disabled Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75321

Patch Set 1 #

Total comments: 3

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -4 lines)			Patch
M	chrome/browser/dom_ui/options/personal_options_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/themes/browser_theme_provider.cc	View	2 chunks	+11 lines, -2 lines	3 comments	Download
M	chrome/browser/ui/gtk/options/content_page_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

This is great -- thanks, Elliot! LGTM w/spelling nitlet. http://codereview.chromium.org/6532033/diff/1/chrome/browser/themes/browser_theme_provider.cc File chrome/browser/themes/browser_theme_provider.cc (right): http://codereview.chromium.org/6532033/diff/1/chrome/browser/themes/browser_theme_provider.cc#newcode48 chrome/browser/themes/browser_theme_provider.cc:48: ...

9 years, 10 months ago (2011-02-17 21:41:46 UTC) #2

Evan Stade

9 years, 10 months ago (2011-02-17 22:13:17 UTC) #3

LGTM

http://codereview.chromium.org/6532033/diff/1/chrome/browser/themes/browser_t...
File chrome/browser/themes/browser_theme_provider.cc (right):

http://codereview.chromium.org/6532033/diff/1/chrome/browser/themes/browser_t...
chrome/browser/themes/browser_theme_provider.cc:343: id ==
kDefatulThemeGalleryID;
On 2011/02/17 21:41:46, Miranda Callahan wrote:
> I actually kind of like the word "Defatul," but still...

I wonder, how do you pronounce it?

Expand Messages | Collapse Messages