Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 6532023: Fix service process to not idle-timeout if Chromoting is enabled. (Closed)

Created:
9 years, 10 months ago by Wez
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Fix service process to not idle-timeout if Chromoting is enabled. When Chromoting is enabled via Chrome, the service process is started if necessary and notified that the Chromoting service has become enabled. When the service process is later auto-started (or run manually) it will initialize Chromoting, which detects that it is enabled and starts up, but fails to inform the service process that it's enabled, so the process waits a while and then exits. BUG=73168 TEST=Enable Chromoting in Chrome. Kill the existing service process and start a new one manually. Ensure that the new one runs for at least two minutes without quitting. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/service/remoting/chromoting_host_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Wez
Trivial short-term fix to keep the service process alive if it auto-starts and Chromoting is ...
9 years, 10 months ago (2011-02-17 11:27:37 UTC) #1
Alpha Left Google
LGTM.
9 years, 10 months ago (2011-02-17 11:28:40 UTC) #2
sanjeevr
LGTM
9 years, 10 months ago (2011-02-17 19:05:51 UTC) #3
Sergey Ulanov
9 years, 10 months ago (2011-02-17 19:20:54 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698