Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6532008: Fix chromium-style compile error that got in the tree since yesterday. (Closed)

Created:
9 years, 10 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), brettw-cc_chromium.org, scherkus (not reviewing), Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org
Visibility:
Public.

Description

Fix chromium-style compile error that got in the tree since yesterday. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75330

Patch Set 1 #

Patch Set 2 : Fixes for Feb 17th #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -12 lines) Patch
M chrome/browser/browser_about_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/render_messages_params.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/render_messages_params.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/test/webdriver/commands/cookie_commands.h View 2 chunks +9 lines, -11 lines 0 comments Download
M chrome/test/webdriver/commands/cookie_commands.cc View 4 chunks +33 lines, -0 lines 0 comments Download
M chrome/test/webdriver/cookie.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/webdriver/cookie.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/mock_filters.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/mock_filters.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Elliot Glaysher
Nico: Review! I need to submit the warnings->error patch for clang soon so I'm not ...
9 years, 10 months ago (2011-02-17 00:10:24 UTC) #1
Elliot Glaysher
Nico: Review! I need to submit the warnings->error patch for clang soon so I'm not ...
9 years, 10 months ago (2011-02-17 00:10:52 UTC) #2
Nico
LG I guess ima write these wiki pages and send out the announcement now :-/
9 years, 10 months ago (2011-02-17 23:15:15 UTC) #3
Elliot Glaysher
On 2011/02/17 23:15:15, Nico wrote: > LG > > I guess ima write these wiki ...
9 years, 10 months ago (2011-02-17 23:18:53 UTC) #4
Nico
9 years, 10 months ago (2011-02-18 00:05:41 UTC) #5 
On Fri, Feb 18, 2011 at 12:18 AM,  <erg@chromium.org> wrote:
> On 2011/02/17 23:15:15, Nico wrote:
>>
>> LG
>
>> I guess ima write these wiki pages and send out the announcement now :-/
>
> FYI:
> http://dev.chromium.org/developers/coding-style/chromium-style-checker-errors
> is
> the documentation for peoples on how to fix there stuffs when things break

Awesome, thanks for this. One less wiki page to write :-)

>
> http://codereview.chromium.org/6532008/
>

Powered by Google App Engine
This is Rietveld 408576698