Use [[DefineOwnProperty]] to put 'constructor' field on the protoype object.

Use [[DefineOwnProperty]] to put 'constructor' field on the protoype object.

That better follows ECMA-262 (see 13.2 Creating Function Objects) and allows
to ignore nasty JS accessors for 'constructor' property.

BUG=v8:1172
TEST=test/mjsunit/regress/regress-1172.js

Committed: http://code.google.com/p/v8/source/detail?r=6849

[antonm, 2011-02-17 19:49:07]

Mads,

may you have a look?

[Mads Ager (chromium), 2011-02-17 20:55:41]

LGTM!

http://codereview.chromium.org/6531037/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6531037/diff/1/src/runtime.cc#newcode6930
src/runtime.cc:6930: RETURN_IF_EMPTY_HANDLE(result);
Shouldn't we be able to create a test case for this. The change looks good, but
can we test it?

[antonm, 2011-02-18 10:40:28]

http://codereview.chromium.org/6531037/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6531037/diff/1/src/runtime.cc#newcode6930
src/runtime.cc:6930: RETURN_IF_EMPTY_HANDLE(result);
On 2011/02/17 20:55:41, Mads Ager wrote:
> Shouldn't we be able to create a test case for this. The change looks good,
but
> can we test it?

I quickly inspected the code and apparently now it's impossible to throw an
exception, so I cannot imagine a regression test for it right now.

Good news is I first added this check and got an expected exception and only
then changes semantics of constructor property installation.

Still I cannot think of a regression test for this line right now.