Issue 6531028: WebUI: Move more files from chrome/browser/dom_ui to chrome/browser/webui. Part 2.

Issue 6531028: WebUI: Move more files from chrome/browser/dom_ui to chrome/browser/webui. Part 2. (Closed)

Created:
9 years, 10 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, Avi (use Gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

WebUI: Move more files from chrome/browser/dom_ui to chrome/browser/webui. Part 2. BUG=59945, 59946 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75315

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -50 lines)			Patch
M	chrome/browser/autocomplete/autocomplete.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/dom_ui/web_ui_factory.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
A +	chrome/browser/webui/bug_report_ui.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/webui/bug_report_ui.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/webui/gpu_internals_ui.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/webui/gpu_internals_ui.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/webui/history2_ui.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/webui/history2_ui.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/webui/history_ui.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/webui/history_ui.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/webui/keyboard_ui.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/webui/keyboard_ui.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	3 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

Code LGTM. Some of these are plain ui, not implementations of webui. Are you going ...

9 years, 10 months ago (2011-02-17 14:42:41 UTC) #2

Avi (use Gerrit)

9 years, 10 months ago (2011-02-17 18:57:16 UTC) #3

Cool!

On Thu, Feb 17, 2011 at 12:13 PM, <tfarina@chromium.org> wrote:

> On 2011/02/17 14:42:41, Avi wrote:
>
>> Code LGTM.
>>
>
>  Some of these are plain ui, not implementations of webui. Are you going to
>> do
>>
> a
>
>> second sweep to move them into ui/webui?
>>
>
> Yeah, I guess that will be the plan.
>
>
>
> http://codereview.chromium.org/6531028/
>

Expand Messages | Collapse Messages