Collect as much GPU information as possible without creating a GL/D3D context...

Collect as much GPU information as possible without creating a GL/D3D context.  If based on such partial information, a graphics card/driver is already blacklisted, we shouldn't even try to establish GPU channel.  This gives us the ability to blacklist REALLY BAD graphics card/driver that will crash during GPU info collection.

BUG=72979
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75473

[Zhenyao Mo, 2011-02-17 02:52:04]

Please review.

[Zhenyao Mo, 2011-02-17 19:13:29]

Try bots are all green.  Also, I manually changed the gpu_blacklist.json to
include my own mac (using vendor/device IDs), and debugged into the process. 
With this CL, gpu is disabled before launching the GPU process and collecting
GPU infor.

[Ken Russell (switch to Gerrit), 2011-02-17 23:08:47]

We've discussed this offline, but I am *very* concerned about adding more
GPU-related work to the browser process. Even if CollectVideoCardInfo is very
safe, if there is any possibility of a crash, it will take down the entire
process, which would be a disaster. I think the way this code should be
structured is that the GPU process, upon initialization, should do the safe
video card gathering, and send an IPC to the browser asking whether the card is
already blacklisted. If so, abort initialization; if not, continue.

[Zhenyao Mo, 2011-02-18 19:37:58]

Revised.  Please review.

[Ken Russell (switch to Gerrit), 2011-02-18 22:21:23]

LGTM. Thanks for doing this restructuring. I really don't like the name "Safe"
and have some suggestions. Would appreciate it if you would choose one. Couple
of other small nits.

http://codereview.chromium.org/6531023/diff/9001/chrome/browser/gpu_process_h...
File chrome/browser/gpu_process_host_ui_shim.cc (right):

http://codereview.chromium.org/6531023/diff/9001/chrome/browser/gpu_process_h...
chrome/browser/gpu_process_host_ui_shim.cc:441: void
GpuProcessHostUIShim::OnGraphicsInfoCollectedSafe(
This name is not really descriptive and also isn't grammatically correct.
Suggestions: OnPartialGraphicsInfoCollected, OnPreliminaryGraphicsInfoCollected,
OnSafeGraphicsInfoCollected.

http://codereview.chromium.org/6531023/diff/9001/chrome/browser/gpu_process_h...
chrome/browser/gpu_process_host_ui_shim.cc:454: logging::LOG_WARNING, "WARNING",
"GPU is blacklisted (SAFE MODE).");
This message isn't useful. Perhaps "GPU is blacklisted based on partial graphics
card information collection."

http://codereview.chromium.org/6531023/diff/9001/chrome/common/gpu_messages_i...
File chrome/common/gpu_messages_internal.h (right):

http://codereview.chromium.org/6531023/diff/9001/chrome/common/gpu_messages_i...
chrome/common/gpu_messages_internal.h:137: // info.
In that case just name it GpuHostMsg_PartialGraphicsInfoCollected.

http://codereview.chromium.org/6531023/diff/9001/chrome/gpu/gpu_info_collector.h
File chrome/gpu/gpu_info_collector.h (right):

http://codereview.chromium.org/6531023/diff/9001/chrome/gpu/gpu_info_collecto...
chrome/gpu/gpu_info_collector.h:26: bool CollectGraphicsInfoSafe(GPUInfo*
gpu_info);
CollectPartialGraphicsInfo? CollectSafeGraphicsInfo?

http://codereview.chromium.org/6531023/diff/9001/chrome/gpu/gpu_thread.cc
File chrome/gpu/gpu_thread.cc (right):

http://codereview.chromium.org/6531023/diff/9001/chrome/gpu/gpu_thread.cc#new...
chrome/gpu/gpu_thread.cc:121: MessageLoop::current()->Quit();
How about a LOG(ERROR) like the other exit paths?

[Zhenyao Mo, 2011-02-18 22:41:52]

Thanks for reviewing this CL.

http://codereview.chromium.org/6531023/diff/9001/chrome/browser/gpu_process_h...
File chrome/browser/gpu_process_host_ui_shim.cc (right):

http://codereview.chromium.org/6531023/diff/9001/chrome/browser/gpu_process_h...
chrome/browser/gpu_process_host_ui_shim.cc:441: void
GpuProcessHostUIShim::OnGraphicsInfoCollectedSafe(
On 2011/02/18 22:21:24, kbr wrote:
> This name is not really descriptive and also isn't grammatically correct.
> Suggestions: OnPartialGraphicsInfoCollected,
OnPreliminaryGraphicsInfoCollected,
> OnSafeGraphicsInfoCollected.

Used Preliminary.

http://codereview.chromium.org/6531023/diff/9001/chrome/browser/gpu_process_h...
chrome/browser/gpu_process_host_ui_shim.cc:454: logging::LOG_WARNING, "WARNING",
"GPU is blacklisted (SAFE MODE).");
On 2011/02/18 22:21:24, kbr wrote:
> This message isn't useful. Perhaps "GPU is blacklisted based on partial
graphics
> card information collection."

Since you suggested to add an error message in the GPU process, no need to log
again here.  Removed.

http://codereview.chromium.org/6531023/diff/9001/chrome/common/gpu_messages_i...
File chrome/common/gpu_messages_internal.h (right):

http://codereview.chromium.org/6531023/diff/9001/chrome/common/gpu_messages_i...
chrome/common/gpu_messages_internal.h:137: // info.
On 2011/02/18 22:21:24, kbr wrote:
> In that case just name it GpuHostMsg_PartialGraphicsInfoCollected.

Used preliminary here to be consistent.

http://codereview.chromium.org/6531023/diff/9001/chrome/gpu/gpu_info_collector.h
File chrome/gpu/gpu_info_collector.h (right):

http://codereview.chromium.org/6531023/diff/9001/chrome/gpu/gpu_info_collecto...
chrome/gpu/gpu_info_collector.h:26: bool CollectGraphicsInfoSafe(GPUInfo*
gpu_info);
On 2011/02/18 22:21:24, kbr wrote:
> CollectPartialGraphicsInfo? CollectSafeGraphicsInfo?

Use preliminary to be consistent

http://codereview.chromium.org/6531023/diff/9001/chrome/gpu/gpu_thread.cc
File chrome/gpu/gpu_thread.cc (right):

http://codereview.chromium.org/6531023/diff/9001/chrome/gpu/gpu_thread.cc#new...
chrome/gpu/gpu_thread.cc:121: MessageLoop::current()->Quit();
On 2011/02/18 22:21:24, kbr wrote:
> How about a LOG(ERROR) like the other exit paths?

Done.