Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 6531022: Removing WS_EX_CLIENTEDGE from the extended styles for the ChromeFrame active... (Closed)

Created:
9 years, 10 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Removing WS_EX_CLIENTEDGE from the extended styles for the ChromeFrame active document. This fixes parts of bug http://code.google.com/p/chromium/issues/detail?id=55764 On IE9 a border is still drawn around all mshtml windows, which does not happen with ChromeFrame. This needs more investigation. BUG=55764 TEST=Launch IE9 and navigate to a ChromeFrame enabled page. The ChromeFrame page should not have a client edge border. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome_frame/chrome_active_document.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 10 months ago (2011-02-17 01:04:27 UTC) #1
amit
9 years, 10 months ago (2011-02-17 21:49:25 UTC) #2
ok

On Wed, Feb 16, 2011 at 5:04 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Removing WS_EX_CLIENTEDGE from the extended styles for the ChromeFrame
> active
> document. This
> fixes parts of bug
> http://code.google.com/p/chromium/issues/detail?id=55764
>
> On IE9 a border is still drawn around all mshtml windows, which does not
> happen
> with ChromeFrame.
> This needs more investigation.
>
> BUG=55764
> TEST=Launch IE9 and navigate to a ChromeFrame enabled page. The ChromeFrame
> page
> should not
>     have a client edge border.
>
>
> Please review this at http://codereview.chromium.org/6531022/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/chrome_active_document.cc
>
>
> Index: chrome_frame/chrome_active_document.cc
> ===================================================================
> --- chrome_frame/chrome_active_document.cc      (revision 74824)
> +++ chrome_frame/chrome_active_document.cc      (working copy)
> @@ -584,7 +584,7 @@
>         ::ShowWindow(m_hWnd, SW_SHOW);
>         SetFocus();
>       } else {
> -        m_hWnd = Create(parent_window, position_rect, 0, 0,
> WS_EX_CLIENTEDGE);
> +        m_hWnd = Create(parent_window, position_rect);
>         if (!IsWindow()) {
>           // This might happen if the automation server couldn't be
>           // instantiated.  If so, a NOTREACHED() will have already been
> hit.
>
>
>

Powered by Google App Engine
This is Rietveld 408576698