The bookmark folder menus look bad when squeezed up against the bottom of a s...

The bookmark folder menus look bad when squeezed up against the bottom of a screen.
Detect this case and automatically switch to showing the menu above the button in this case.
BUG=69996
TEST=NONE

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75342

[mrossetti, 2011-02-17 03:38:30]

Don't forget to use bookmarks::kScrollWindowVerticalMargin for help in
determining how close the bottom of the popup menu window can get to the visible
bottom.

http://codereview.chromium.org/6531019/diff/4001/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
(right):

http://codereview.chromium.org/6531019/diff/4001/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:462: CGFloat
kMinSqueezedMenuHeight = 40.0;
It would probably be better if this constant were based on established constants
such as bookmarks::kBookmarkFolderButtonHeight and
      bookmarks::kBookmarkVerticalPadding.

http://codereview.chromium.org/6531019/diff/4001/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:493: if
((newWindowTopLeft.y - NSMinY(visFrame) < kMinSqueezedMenuHeight) &&
Have you tried this with a bookmark bar folder which is empty or which has only
one bookmark?

[mafv, 2011-02-17 21:25:00]

OK, now new and improved.

http://codereview.chromium.org/6531019/diff/4001/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
(right):

http://codereview.chromium.org/6531019/diff/4001/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:462: CGFloat
kMinSqueezedMenuHeight = 40.0;
On 2011/02/17 03:38:30, mrossetti wrote:
> It would probably be better if this constant were based on established
constants
> such as bookmarks::kBookmarkFolderButtonHeight and
>       bookmarks::kBookmarkVerticalPadding.

Done.  This is now based on kBookmarkFolderButtonHeight and I factor in the
other constant in the space calculation below.

http://codereview.chromium.org/6531019/diff/4001/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:493: if
((newWindowTopLeft.y - NSMinY(visFrame) < kMinSqueezedMenuHeight) &&
On 2011/02/17 03:38:30, mrossetti wrote:
> Have you tried this with a bookmark bar folder which is empty or which has
only
> one bookmark?
Yes.

[mrossetti, 2011-02-18 00:45:34]

LGTM, actually LVGTM