image_to_live.sh: fix ip address detection

image_to_live.sh: fix ip address detection

Change-Id: I6d05da5d1deaf45c42a3285c105fd310a588ef4e

BUG=5246
TEST=update an image, live

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9a77656

[petkov, 2011-02-16 23:37:54]

I assume the script uses sudo in other places too?

http://codereview.chromium.org/6531005/diff/1/image_to_live.sh
File image_to_live.sh (right):

http://codereview.chromium.org/6531005/diff/1/image_to_live.sh#newcode110
image_to_live.sh:110: hostname=$(sudo ifconfig eth0 \
fix per style -- if the pipe doesn't fit on one line, each element on a separate
line; | at the end of each line with no trailing \

http://codereview.chromium.org/6531005/diff/1/image_to_live.sh#newcode114
image_to_live.sh:114: [ -z "${hostname}" ] && hostname=$HOSTNAME
${HOSTNAME}

[zbehan, 2011-02-17 00:19:10]

On Thu, Feb 17, 2011 at 12:37 AM, <petkov@chromium.org> wrote:

> I assume the script uses sudo in other places too?
>

Yes, it uses sudo in many places, at the very least for calling chroot.

http://codereview.chromium.org/6531005/diff/1/image_to_live.sh
> File image_to_live.sh (right):
>
> http://codereview.chromium.org/6531005/diff/1/image_to_live.sh#newcode110
> image_to_live.sh:110: hostname=$(sudo ifconfig eth0 \
> fix per style -- if the pipe doesn't fit on one line, each element on a
> separate line; | at the end of each line with no trailing \
>
> http://codereview.chromium.org/6531005/diff/1/image_to_live.sh#newcode114
> image_to_live.sh:114: [ -z "${hostname}" ] && hostname=$HOSTNAME
> ${HOSTNAME}
>
>
> http://codereview.chromium.org/6531005/
>

[zbehan, 2011-02-17 19:49:52]

Fixed the style, too, PTAL

On Thu, Feb 17, 2011 at 8:49 PM, <zbehan@chromium.org> wrote:

> http://codereview.chromium.org/6531005/
>

[petkov, 2011-02-17 23:41:33]

LGTM w/ a nit.

http://codereview.chromium.org/6531005/diff/6001/image_to_live.sh
File image_to_live.sh (right):

http://codereview.chromium.org/6531005/diff/6001/image_to_live.sh#newcode116
image_to_live.sh:116: [ -z "${hostname}" ] && hostname=$HOSTNAME
${HOSTNAME}

[zbehan, 2011-02-17 23:54:24]

Fixed, pushed, thx.

On Fri, Feb 18, 2011 at 12:41 AM, <petkov@chromium.org> wrote:

> LGTM w/ a nit.
>
>
> http://codereview.chromium.org/6531005/diff/6001/image_to_live.sh
>
> File image_to_live.sh (right):
>
>
> http://codereview.chromium.org/6531005/diff/6001/image_to_live.sh#newcode116
> image_to_live.sh:116: [ -z "${hostname}" ] && hostname=$HOSTNAME
> ${HOSTNAME}
>
> http://codereview.chromium.org/6531005/
>