Issue 6529052: X64 Crankshaft: Implement LCallFunction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6529052: X64 Crankshaft: Implement LCallFunction. (Closed)

Created:
9 years, 10 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64 Crankshaft: Implement LCallFunction. Committed: http://code.google.com/p/v8/source/detail?r=6825

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download
	M	src/x64/lithium-x64.h	View		1 chunk	+6 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/6529052/diff/1/src/x64/lithium-x64.h File src/x64/lithium-x64.h (right): http://codereview.chromium.org/6529052/diff/1/src/x64/lithium-x64.h#newcode1326 src/x64/lithium-x64.h:1326: LOperand* context() { return inputs_[0]; } We only ...

9 years, 10 months ago (2011-02-16 14:47:48 UTC) #2

William Hesse

9 years, 10 months ago (2011-02-16 15:06:25 UTC) #3

On 2011/02/16 14:47:48, Rico wrote:
> LGTM
> 
> http://codereview.chromium.org/6529052/diff/1/src/x64/lithium-x64.h
> File src/x64/lithium-x64.h (right):
> 
>
http://codereview.chromium.org/6529052/diff/1/src/x64/lithium-x64.h#newcode1326
> src/x64/lithium-x64.h:1326: LOperand* context() { return inputs_[0]; }
> We only seem to use this in an assert?
It is also used when creating the LCallFunction (not the accessor, but the
field).  So the assert is necessary.

Expand Messages | Collapse Messages