Issue 6529024: X64 Crankshaft: Implement InstanceOf and InstanceOfKnownGlobal

Issue 6529024: X64 Crankshaft: Implement InstanceOf and InstanceOfKnownGlobal (Closed)

Created:
9 years, 10 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64 Crankshaft: Implement InstanceOf and InstanceOfKnownGlobal Committed: http://code.google.com/p/v8/source/detail?r=6824

Patch Set 4 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -20 lines)			Patch
M	src/x64/code-stubs-x64.cc	View	1 2 3	2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2 3	3 chunks	+71 lines, -6 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1 2 3	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 2 3	2 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/6529024/diff/3001/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/6529024/diff/3001/src/x64/code-stubs-x64.cc#newcode3464 src/x64/code-stubs-x64.cc:3464: // None of the flags is supported on ...

9 years, 10 months ago (2011-02-16 14:43:25 UTC) #1

William Hesse

9 years, 10 months ago (2011-02-16 15:15:06 UTC) #2

http://codereview.chromium.org/6529024/diff/3001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

http://codereview.chromium.org/6529024/diff/3001/src/x64/code-stubs-x64.cc#ne...
src/x64/code-stubs-x64.cc:3464: // None of the flags is supported on X64.
On 2011/02/16 14:43:25, Rico wrote:
> is -> are

Done.

http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:1607: NearLabel true_value, done;
On 2011/02/16 14:43:25, Rico wrote:
> Maybe put labels above the testq minimize diff to ia32

Done.

http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:1664: // Here result has either true or false.
Deferred code also produces true or
Comment deleted.

On 2011/02/16 14:43:25, Rico wrote:
> it never has true here does it?

http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):

http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-x64.cc#newco...
src/x64/lithium-x64.cc:1085: UseFixed(instance_of->right()), rdx);
On 2011/02/16 14:43:25, Rico wrote:
> is the parenthesis not in the wrong place above? rdx is the fixed register we
> should use right? Does this even compile?

This was a last minute change.  This is dead code, but it didn't compile until I
fixed it.

Expand Messages | Collapse Messages