Issue 6529022: ARM: Add inlined smi binary operations in full code generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6529022: ARM: Add inlined smi binary operations in full code generator (Closed)

Created:
9 years, 10 months ago by Søren Thygesen Gjesse

Modified:
9 years, 10 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Add inlined smi binary operations in full code generator Committed: http://code.google.com/p/v8/source/detail?r=6806

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+327 lines, -13 lines)			Patch
	M	src/arm/full-codegen-arm.cc	View	1 2	4 chunks	+315 lines, -8 lines	0 comments	Download
	M	src/ia32/full-codegen-ia32.cc	View	1 2	7 chunks	+12 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 10 months ago (2011-02-16 08:31:53 UTC) #2

LGTM

http://codereview.chromium.org/6529022/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/6529022/diff/1/src/arm/full-codegen-arm.cc#new...
src/arm/full-codegen-arm.cc:1719: __ tst(r1, Operand(0xc0000000));
Could we add a comment here. This is not completely obvious. This mask ensures
that smi tagging will not overflow and that the result will be positive. Only
needed if you shift by less than two.

http://codereview.chromium.org/6529022/diff/1/src/arm/full-codegen-arm.cc#new...
src/arm/full-codegen-arm.cc:1842: // Smi case. This code works the same way as
the smi-smi case in the type
I wonder if we can put these pieces of smi code in shared helper functions
somehow. Seems silly to duplicate all this. Feel free to commit this, but we
should see if we can share it.

Expand Messages | Collapse Messages