Add --quiet to run_remote_tests, and use it

Add --quiet to run_remote_tests, and use it

Change-Id: I91f490ba4c4a834ba01b671c56c63ba230561ada

BUG=chromium-os:11680
TEST=Manual

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5b7e1d5

[dgarrett, 2011-02-15 03:22:24]

--verbose means to run autoserv with --verbose. Right now you can use both and
it means you get the DEBUG output from the tests, but only if test fails.

However, maybe we want to do something different with the options. If you know
what makes for a good interface, I'll change to use it.

Let me know what you think otherwise.

[dgarrett, 2011-02-15 20:01:33]

PTAL

[sosa, 2011-02-15 22:16:47]

LG overall.  Cpl questions/ comments.  Sorry for taking so long to get to this
... I thought I hit publish a cpl times but sadly failed to recollect correctly

http://codereview.chromium.org/6529010/diff/3001/run_remote_tests.sh
File run_remote_tests.sh (right):

http://codereview.chromium.org/6529010/diff/3001/run_remote_tests.sh#newcode45
run_remote_tests.sh:45: DEFINE_boolean quiet ${FLAGS_FALSE} "Hide most test logs
on success"
maybe hide_info?

http://codereview.chromium.org/6529010/diff/3001/run_remote_tests.sh#newcode333
run_remote_tests.sh:333: result="$(./server/autoserv ${autoserv_args} 2>&1)"
I'm not sure this'll work with || to some var ... i.e. DO something || error=1
... if $error -eq 1.  Set -e would kick in before you could check for $?
otherwise

[dgarrett, 2011-02-15 22:52:16]

PTAL.

Renamed the option, and dealt with -e problems, even did a test via kill
autoserv.

[sosa, 2011-02-16 00:13:51]

http://codereview.chromium.org/6529010/diff/4003/run_remote_tests.sh
File run_remote_tests.sh (right):

http://codereview.chromium.org/6529010/diff/4003/run_remote_tests.sh#newcode335
run_remote_tests.sh:335: fi
It is preferred not to set +e / set -e in a block ... but rather || individual
lines.

[dgarrett, 2011-02-16 00:40:48]

http://codereview.chromium.org/6529010/diff/4003/run_remote_tests.sh
File run_remote_tests.sh (right):

http://codereview.chromium.org/6529010/diff/4003/run_remote_tests.sh#newcode335
run_remote_tests.sh:335: fi
Which which exact syntax, and do you lose the result code when you do that?

[sosa, 2011-02-16 00:46:42]

Just meant to do something more like:

 result="$(ssh-add $tmp_private_key 2>&1)" || die "$result"

On Tue, Feb 15, 2011 at 4:40 PM,  <dgarrett@chromium.org> wrote:
>
> http://codereview.chromium.org/6529010/diff/4003/run_remote_tests.sh
> File run_remote_tests.sh (right):
>
>
http://codereview.chromium.org/6529010/diff/4003/run_remote_tests.sh#newcode335
> run_remote_tests.sh:335: fi
> Which which exact syntax, and do you lose the result code when you do
> that?
>
> http://codereview.chromium.org/6529010/
>

[sosa, 2011-02-16 00:47:20]

For example:

returnval=0
result="$(ssh-add $tmp_private_key 2>&1)" || return_val=1

On Tue, Feb 15, 2011 at 4:46 PM, Chris Sosa <sosa@chromium.org> wrote:
> Just meant to do something more like:
>
>  result="$(ssh-add $tmp_private_key 2>&1)" || die "$result"
>
> On Tue, Feb 15, 2011 at 4:40 PM,  <dgarrett@chromium.org> wrote:
>>
>> http://codereview.chromium.org/6529010/diff/4003/run_remote_tests.sh
>> File run_remote_tests.sh (right):
>>
>>
http://codereview.chromium.org/6529010/diff/4003/run_remote_tests.sh#newcode335
>> run_remote_tests.sh:335: fi
>> Which which exact syntax, and do you lose the result code when you do
>> that?
>>
>> http://codereview.chromium.org/6529010/
>>
>

[dgarrett, 2011-02-16 01:06:32]

Okay, got it. I hope. Finally.

http://codereview.chromium.org/6529010/diff/4003/run_remote_tests.sh
File run_remote_tests.sh (right):

http://codereview.chromium.org/6529010/diff/4003/run_remote_tests.sh#newcode335
run_remote_tests.sh:335: fi
On 2011/02/16 00:40:48, dgarrett wrote:
> Which which exact syntax, and do you lose the result code when you do that?

Done.

[sosa, 2011-02-16 01:07:20]

LGTM

[sosa, 2011-02-16 01:07:21]

LGTM