Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 6529006: Don't call the zlib functions with the MOZ_Z_ prefix... (Closed)

Created:
9 years, 10 months ago by wtc
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, Paweł Hajdan Jr., dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Don't call the zlib functions with the MOZ_Z_ prefix in the source code. R=agl,hclam,jar BUG=none TEST=No build or test failures Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -35 lines) Patch
M net/base/gzip_filter.cc View 4 chunks +4 lines, -13 lines 0 comments Download
M net/base/gzip_filter_unittest.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M remoting/base/compressor_zlib.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M remoting/base/decompressor_zlib.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wtc
The MOZ_Z_ prefix in our copy of zlib (src/third_party/zlib) comes from Mozilla. But even Mozilla ...
9 years, 10 months ago (2011-02-15 01:51:23 UTC) #1
jar (doing other things)
LGTM++
9 years, 10 months ago (2011-02-15 04:23:47 UTC) #2
agl
LGTM. Glad to see that this bit of braindamage is gone.
9 years, 10 months ago (2011-02-15 14:30:21 UTC) #3
commit-bot: I haz the power
Can't process patch for file net/base/gzip_filter_unittest.cc.
9 years, 10 months ago (2011-02-15 14:57:58 UTC) #4
commit-bot: I haz the power
9 years, 10 months ago (2011-02-15 15:44:00 UTC) #5
Can't process patch for file net/base/gzip_filter_unittest.cc.

Powered by Google App Engine
This is Rietveld 408576698