Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 6528046: Update memcheck to valgrind-variant r80... (Closed)

Created:
9 years, 10 months ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update memcheck to valgrind-variant r80 This only affects Linux, shouldn't cause much difference with Mac TBR=glider TEST=Memory waterfall doesn't change much BUG=73024 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75105

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
Timur Iskhodzhanov
9 years, 10 months ago (2011-02-16 12:13:54 UTC) #1
Alexander Potapenko
9 years, 10 months ago (2011-02-16 12:23:01 UTC) #2
LGTM

On Wed, Feb 16, 2011 at 3:13 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Update memcheck to valgrind-variant r80
> This only affects Linux, shouldn't cause much difference with Mac
> TBR=glider
> TEST=Memory waterfall doesn't change much
>
> Please review this at http://codereview.chromium.org/6528046/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/
>
> Affected files:
>  M     binaries/linux_x64/bin/valgrind
>  M     binaries/linux_x64/bin/valgrind-tsan.sh
>  M     binaries/linux_x64/lib/valgrind/memcheck-amd64-linux
>  M     binaries/linux_x64/lib/valgrind/memcheck-x86-linux
>  M     binaries/linux_x64/lib/valgrind/vgpreload_memcheck-amd64-linux.so
>  M     binaries/linux_x64/lib/valgrind/vgpreload_memcheck-x86-linux.so
>  M     binaries/linux_x86/bin/valgrind
>  M     binaries/linux_x86/bin/valgrind-tsan.sh
>  M     binaries/linux_x86/lib/valgrind/memcheck-x86-linux
>  M     binaries/linux_x86/lib/valgrind/vgpreload_memcheck-x86-linux.so
>  M     scripts/build-memcheck-for-chromium.sh
>
>
> Index: binaries/linux_x64/bin/valgrind
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x64/bin/valgrind-tsan.sh
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x64/lib/valgrind/memcheck-amd64-linux
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x64/lib/valgrind/memcheck-x86-linux
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x64/lib/valgrind/vgpreload_memcheck-amd64-linux.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x64/lib/valgrind/vgpreload_memcheck-x86-linux.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x86/bin/valgrind
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x86/bin/valgrind-tsan.sh
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x86/lib/valgrind/memcheck-x86-linux
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x86/lib/valgrind/vgpreload_memcheck-x86-linux.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: scripts/build-memcheck-for-chromium.sh
> ===================================================================
> --- scripts/build-memcheck-for-chromium.sh      (revision 75104)
> +++ scripts/build-memcheck-for-chromium.sh      (working copy)
> @@ -9,7 +9,7 @@
>
>  # SVN isn't smart enough to figure out what rev of VEX to get,
>  # so you have to check that out by revision.
> -MEMCHECK_VV_REV=76
> +MEMCHECK_VV_REV=80
>
>  VG_MEMCHECK_DIR="$VG_SRC_DIR/valgrind-memcheck"
>  checkout_and_patch_valgrind_variant "$MEMCHECK_VV_REV" "$VG_MEMCHECK_DIR"
>
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

Powered by Google App Engine
This is Rietveld 408576698