Cleanup: Make chrome paths code more consistent and use more constants when p...

Cleanup: Make chrome paths code more consistent and use more constants when possible.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75289

[viettrungluu, 2011-02-16 16:34:25]

LGTM with nits.

http://codereview.chromium.org/6528028/diff/1/chrome/common/chrome_paths.cc
File chrome/common/chrome_paths.cc (right):

http://codereview.chromium.org/6528028/diff/1/chrome/common/chrome_paths.cc#n...
chrome/common/chrome_paths.cc:48: // TODO(noelallen) Please verify this
extention name is correct.
nit: re-align comment

http://codereview.chromium.org/6528028/diff/1/chrome/common/chrome_paths_linu...
File chrome/common/chrome_paths_linux.cc (right):

http://codereview.chromium.org/6528028/diff/1/chrome/common/chrome_paths_linu...
chrome/common/chrome_paths_linux.cc:15: const char kDotConfig[] = ".config";
These already have internal linkage, so the anonymous namespace is redundant,
but I guess it's more clear this way.

Real nit: Slightly more descriptive names might be helpful. E.g.,
"kDotConfigFile(Name?)", "kDownloadsDirectory(Name?)",
"kXdgConfigHomeVariable(Name?)".

[Lei Zhang, 2011-02-17 03:19:46]

http://codereview.chromium.org/6528028/diff/1/chrome/common/chrome_paths.cc
File chrome/common/chrome_paths.cc (right):

http://codereview.chromium.org/6528028/diff/1/chrome/common/chrome_paths.cc#n...
chrome/common/chrome_paths.cc:48: // TODO(noelallen) Please verify this
extention name is correct.
On 2011/02/16 16:34:25, viettrungluu wrote:
> nit: re-align comment

Done.

http://codereview.chromium.org/6528028/diff/1/chrome/common/chrome_paths_linu...
File chrome/common/chrome_paths_linux.cc (right):

http://codereview.chromium.org/6528028/diff/1/chrome/common/chrome_paths_linu...
chrome/common/chrome_paths_linux.cc:15: const char kDotConfig[] = ".config";
On 2011/02/16 16:34:25, viettrungluu wrote:
> These already have internal linkage, so the anonymous namespace is redundant,
> but I guess it's more clear this way.
> 
> Real nit: Slightly more descriptive names might be helpful. E.g.,
> "kDotConfigFile(Name?)", "kDownloadsDirectory(Name?)",
> "kXdgConfigHomeVariable(Name?)".

Done.

[viettrungluu, 2011-02-17 04:24:14]

Still LG, but now my head is less itchy. Thanks.