Issue 6528006: AU: tolerate files that are symlinks in src image, yet not in new image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6528006: AU: tolerate files that are symlinks in src image, yet not in new image. (Closed)

Created:
9 years, 10 months ago by adlr

Modified:
9 years ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
http://git.chromium.org/git/update_engine.git@master

Visibility:
Public.

Description

AU: tolerate files that are symlinks in src image, yet not in new image. This fixes a bug in delta diff generation. BUG=chromium-os:12090 TEST=unittests; generated delta w/ problematic images Change-Id: Ic48b012d0d9e4f37edbdcf4140d0fe9c4879e7cd Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=29da8aa

Patch Set 1 #

Patch Set 2 : clean up logging #

Patch Set 3 : fix cleanup #

Total comments: 2

Patch Set 4 : fixes for review #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -4 lines)			Patch
M	delta_diff_generator.cc	View	1 2 3	5 chunks	+28 lines, -3 lines	0 comments	Download
M	delta_performer_unittest.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	test_utils.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

i'm rerunning the tests after cleanup up logging. Will make sure those pass before checking ...

9 years, 10 months ago (2011-02-15 01:26:41 UTC) #1

petkov

LGTM w/ a couple of suggestions. It might be nice to figure out what changed ...

9 years, 10 months ago (2011-02-15 06:01:38 UTC) #2

Thanks. fixed and retested. Pushing now

Expand Messages | Collapse Messages