Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 6526047: Shorten live ranges for arguments to runtime calls. (Closed)

Created:
9 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Shorten live ranges for arguments to runtime calls. Before, the live ranges of the arguments extended to the call itself, and they were pushed immediately before the call. Now, they are spilled eagerly as soon as their value is available and they are spilled to the right place. The inlined runtime calls in the optimized backend are changed to work as in all the other backends: they get their arguments untranslated and can choose their own custom evaluation order. Committed: http://code.google.com/p/v8/source/detail?r=6876

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -170 lines) Patch
M src/hydrogen.h View 3 chunks +7 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 13 chunks +178 lines, -162 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/lithium.h View 1 chunk +5 lines, -3 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 10 months ago (2011-02-16 13:10:28 UTC) #1
fschneider
9 years, 10 months ago (2011-02-21 17:02:01 UTC) #2
LGTM.

http://codereview.chromium.org/6526047/diff/1/src/lithium.h
File src/lithium.h (right):

http://codereview.chromium.org/6526047/diff/1/src/lithium.h#newcode540
src/lithium.h:540: return op == NULL || op->IsConstantOperand() ||
op->IsArgument();
Just wondering: Was this already a problem before to have LArgument operands in
the enumeration of environment uses not skipped?

Powered by Google App Engine
This is Rietveld 408576698