Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: src/arguments.h

Issue 6526046: Handle indexed properties on value objects correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 Object** arguments_; 71 Object** arguments_;
72 }; 72 };
73 73
74 74
75 // Custom arguments replicate a small segment of stack that can be 75 // Custom arguments replicate a small segment of stack that can be
76 // accessed through an Arguments object the same way the actual stack 76 // accessed through an Arguments object the same way the actual stack
77 // can. 77 // can.
78 class CustomArguments : public Relocatable { 78 class CustomArguments : public Relocatable {
79 public: 79 public:
80 inline CustomArguments(Object* data, 80 inline CustomArguments(Object* data,
81 JSObject* self, 81 Object* self,
82 JSObject* holder) { 82 JSObject* holder) {
83 values_[2] = self; 83 values_[2] = self;
84 values_[1] = holder; 84 values_[1] = holder;
85 values_[0] = data; 85 values_[0] = data;
86 } 86 }
87 87
88 inline CustomArguments() { 88 inline CustomArguments() {
89 #ifdef DEBUG 89 #ifdef DEBUG
90 for (size_t i = 0; i < ARRAY_SIZE(values_); i++) { 90 for (size_t i = 0; i < ARRAY_SIZE(values_); i++) {
91 values_[i] = reinterpret_cast<Object*>(kZapValue); 91 values_[i] = reinterpret_cast<Object*>(kZapValue);
92 } 92 }
93 #endif 93 #endif
94 } 94 }
95 95
96 void IterateInstance(ObjectVisitor* v); 96 void IterateInstance(ObjectVisitor* v);
97 Object** end() { return values_ + ARRAY_SIZE(values_) - 1; } 97 Object** end() { return values_ + ARRAY_SIZE(values_) - 1; }
98 private: 98 private:
99 Object* values_[3]; 99 Object* values_[3];
100 }; 100 };
101 101
102 102
103 } } // namespace v8::internal 103 } } // namespace v8::internal
104 104
105 #endif // V8_ARGUMENTS_H_ 105 #endif // V8_ARGUMENTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698