chrome/browser/safe_browsing/safe_browsing_test.cc - Issue 6526040: CommandLine refactoring and cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_test.cc

Issue 6526040: CommandLine refactoring and cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address additional comments, additional refactoring. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/safe_browsing_test.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_test.cc b/chrome/browser/safe_browsing/safe_browsing_test.cc

index 53c65fe041407553db57fd3decfa71dae61dead7..65a68df6f7ea828e2ba9fe127d6cbb44164b4493 100644

--- a/chrome/browser/safe_browsing/safe_browsing_test.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_test.cc

@@ -141,8 +141,9 @@ class SafeBrowsingTestServer {

CommandLine cmd_line(python_runtime);

FilePath datafile = testserver_path.Append(datafile_);

cmd_line.AppendArgPath(testserver);

- cmd_line.AppendSwitchASCII("port", StringPrintf("%d", kPort_));

- cmd_line.AppendSwitchPath("datafile", datafile);

+ cmd_line.AppendArg("--port=" + base::IntToString(kPort_));

+ cmd_line.AppendArgNative(FILE_PATH_LITERAL("--datafile=") +

+ datafile.value());

if (!base::LaunchApp(cmd_line, false, true, &server_handle_)) {

LOG(ERROR) << "Failed to launch server: "