CommandLine refactoring and cleanup.

chrome/browser/safe_browsing/safe_browsing_test.cc

Index: chrome/browser/safe_browsing/safe_browsing_test.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_test.cc b/chrome/browser/safe_browsing/safe_browsing_test.cc
index 53c65fe041407553db57fd3decfa71dae61dead7..65a68df6f7ea828e2ba9fe127d6cbb44164b4493 100644
--- a/chrome/browser/safe_browsing/safe_browsing_test.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_test.cc
@@ -141,8 +141,9 @@ class SafeBrowsingTestServer {
     CommandLine cmd_line(python_runtime);
     FilePath datafile = testserver_path.Append(datafile_);
     cmd_line.AppendArgPath(testserver);
-    cmd_line.AppendSwitchASCII("port", StringPrintf("%d", kPort_));
-    cmd_line.AppendSwitchPath("datafile", datafile);
+    cmd_line.AppendArg("--port=" + base::IntToString(kPort_));
+    cmd_line.AppendArgNative(FILE_PATH_LITERAL("--datafile=") +
+                             datafile.value());

[Evan Martin, 2011/05/10 23:48:32]

Why not AppendSwitch for these?

[msw, 2011/05/11 02:28:12]

Because Python syntax requires the script (testserver) to precede any arguments
to the script. I merely restored the CommandLine argv_ order for LaunchApp's use
of command_line_string() with Python to fix affected test(s).

 
     if (!base::LaunchApp(cmd_line, false, true, &server_handle_)) {
       LOG(ERROR) << "Failed to launch server: "