Issue 6526039: Show settings/personal when attempting to call ShowLoginDialog for ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6526039: Show settings/personal when attempting to call ShowLoginDialog for ChromeOS. (Closed)

Created:
9 years, 10 months ago by stevenjb

Modified:
9 years, 7 months ago

Reviewers:
John Gregg, akalin

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Show settings/personal when attempting to call ShowLoginDialog for ChromeOS. BUG=chromium-os:12187 TEST=See issue Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75200

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/sync/profile_sync_service.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

stevenjb

One more less critical change for R10. See the issue for the details.

9 years, 10 months ago (2011-02-16 04:19:31 UTC) #1

James Hawkins

-jhawkins since I don't know the implications of this decision.

9 years, 10 months ago (2011-02-16 19:57:28 UTC) #2

akalin

9 years, 10 months ago (2011-02-16 20:49:42 UTC) #3

LGTM

On 2011/02/16 19:57:28, James Hawkins wrote:
> -jhawkins since I don't know the implications of this decision.