Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: Source/WebCore/platform/SharedBuffer.h

Issue 6526023: Merge 78548 - 2011-02-15 Gavin Peters <gavinp@chromium.org>... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/648/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/platform/SharedBuffer.h
===================================================================
--- Source/WebCore/platform/SharedBuffer.h (revision 78612)
+++ Source/WebCore/platform/SharedBuffer.h (working copy)
@@ -81,10 +81,6 @@
unsigned size() const;
- // Calling this function will force internal segmented buffers
- // to be merged into a flat buffer. Use getSomeData() whenever possible
- // for better performance.
- const Vector<char>& buffer() const;
bool isEmpty() const { return !size(); }
@@ -119,6 +115,13 @@
SharedBuffer(const char*, int);
SharedBuffer(const unsigned char*, int);
+ // Calling this function will force internal segmented buffers
+ // to be merged into a flat buffer. Use getSomeData() whenever possible
+ // for better performance.
+ // As well, be aware that this method does *not* return any purgeable
+ // memory, which can be a source of bugs.
+ const Vector<char>& buffer() const;
+
void clearPlatformData();
void maybeTransferPlatformData();
bool hasPlatformData() const;

Powered by Google App Engine
This is Rietveld 408576698