Issue 6526022: Remove .config which was moved to another git

Issue 6526022: Remove .config which was moved to another git (Closed)

Created:
9 years, 10 months ago by jimhebert

Modified:
9 years, 7 months ago

Reviewers:
gauravsh

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Description

Remove .config which was moved to another git Change-Id: I4e185a5d08dee381d516683e4eda6f3404b6a060 BUG=chrome-os-partner:1991 TEST=none Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1a4620e

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -40 lines)			Patch
	D	scripts/image_signing/ensure_secure_kernelparams.config	View		1 chunk	+0 lines, -40 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gauravsh

lgtm (weren't there additional config files that were also moved?)

9 years, 10 months ago (2011-02-15 22:05:49 UTC) #2

jimhebert

There were 2 added to the other git, but one of those was never added ...

9 years, 10 months ago (2011-02-15 22:54:20 UTC) #3

gauravsh

9 years, 10 months ago (2011-02-15 23:06:11 UTC) #4

On Tue, Feb 15, 2011 at 2:54 PM, Jim Hebert <jimhebert@chromium.org> wrote:
> There were 2 added to the other git, but one of those was never added to
> this git.  (I tried to add it, but we caught that during CL review and it
> was removed before the CL ever was pushed.)
> There is a third config file (the blacklist of files that should not exist
> in a pristine release build) that is staying vboot reference at the moment.
>  We moved the ones that had references to specific boards where we would
> tend to leak new board names over time.  Since that one was board-neutral I
> figured it could stay public.  If you'd rather I move it too just for the
> sake of them all being in one place, I can.

I think it would be simpler if we had all the specific config files
all checked into one place. However, at the same time, we would still
want skeleton files (documenting the format) in the original location
(vboot_reference).

> Thanks for double-checking me!
> jim
>
> On Tue, Feb 15, 2011 at 2:05 PM, <gauravsh@chromium.org> wrote:
>>
>> lgtm
>>
>> (weren't there additional config files that were also moved?)
>>
>>
>> http://codereview.chromium.org/6526022/
>
>



-- 
-g

Expand Messages | Collapse Messages