Issue 6525034: Don't log chrome SIGABRT crashes during logout.

Issue 6525034: Don't log chrome SIGABRT crashes during logout. (Closed)

Created:
9 years, 10 months ago by DaleCurtis

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone, ericli

CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/autotest.git@master

Visibility:
Public.

Description

Don't log chrome SIGABRT crashes during logout. Per discussion with cmasone, SIGABRT crashes should be ignored during logout. BUG=chromium-os:12100 TEST=Ran run_remote_tests w/ good build and bad build. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=44d8a98

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Long line. #

Total comments: 3

Patch Set 4 : Code review fixes. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -24 lines)			Patch
	M	client/cros/cros_ui_test.py	View	1 2 3	1 chunk	+21 lines, -7 lines	0 comments	Download
	M	client/cros/login.py	View	1 2	2 chunks	+29 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

DaleCurtis

http://codereview.chromium.org/6525034/diff/5/client/cros/cros_ui_test.py File client/cros/cros_ui_test.py (right): http://codereview.chromium.org/6525034/diff/5/client/cros/cros_ui_test.py#newcode296 client/cros/cros_ui_test.py:296: logout_start_regex = re.compile(login.LOGOUT_ATTEMPT_MSG) I realize there's a regular expression ...

9 years, 10 months ago (2011-02-15 23:45:42 UTC) #1

Chris Masone

LGTM with nit On 2011/02/15 23:45:42, dalec wrote: > http://codereview.chromium.org/6525034/diff/5/client/cros/cros_ui_test.py > File client/cros/cros_ui_test.py (right): > ...

9 years, 10 months ago (2011-02-16 00:38:10 UTC) #2

Chris Masone

http://codereview.chromium.org/6525034/diff/5/client/cros/cros_ui_test.py File client/cros/cros_ui_test.py (right): http://codereview.chromium.org/6525034/diff/5/client/cros/cros_ui_test.py#newcode310 client/cros/cros_ui_test.py:310: not (in_logout and match.group(1) == 'chrome' and can you ...

9 years, 10 months ago (2011-02-16 00:38:32 UTC) #3

DaleCurtis

9 years, 10 months ago (2011-02-16 01:20:08 UTC) #4

http://codereview.chromium.org/6525034/diff/5/client/cros/cros_ui_test.py
File client/cros/cros_ui_test.py (right):

http://codereview.chromium.org/6525034/diff/5/client/cros/cros_ui_test.py#new...
client/cros/cros_ui_test.py:310: not (in_logout and match.group(1) == 'chrome'
and
On 2011/02/16 00:38:32, Chris Masone wrote:
> can you use constants.BROWSER instead of 'chrome'?

Done.

Expand Messages | Collapse Messages