Issue 6525020: enter_chroot: Only mount SSH auth socket when we need to.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6525020: enter_chroot: Only mount SSH auth socket when we need to. (Closed)

Created:
9 years, 10 months ago by rochberg

Modified:
9 years, 7 months ago

Reviewers:
dgarrett

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

enter_chroot: Only mount SSH auth socket when we need to. Also refactors some cut-and-paste code Fix: makes mountpoint for subversion directory BUG=chromium-os:11944 chromium-os:12058 TEST=enter_chroot.sh with and without another enter_chroot running. Note that there are 0 or 1 mounts of the /tmp/ssh-.... directory. Check that /proc,/sys,/dev,$SSH_AUTH_SOCK,/dev/pts,/home/${USER}/trunk,/home/${USER}/.subversion are all mounted. Test that subversion mountpoint is created Change-Id: I9dada6f7f98d263345af29a5734c1c70709f6a1e Review URL: http://codereview.chromium.org/6498001 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=351a76f

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -43 lines)			Patch
	M	enter_chroot.sh	View		5 chunks	+28 lines, -43 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dgarrett

9 years, 10 months ago (2011-02-16 01:13:03 UTC) #2

LGTM

Looks like a good clean up as well as a bug fix. ;>

Expand Messages | Collapse Messages