Adding callbacks to `chrome.cookies.{set,remove}`.

chrome/test/data/extensions/api_test/cookies/api/tab.html

 <script>
 var TEST_DOMAIN = 'cookies.com';
 var TEST_PATH = '/auth';
 var TEST_HOST = 'www.chrome_extensions.' + TEST_DOMAIN;
 var TEST_URL = 'http://' + TEST_HOST + '/foobar.html?arg=toolbar&param=true';
 var TEST_URL2 = 'http://chromium.' + TEST_DOMAIN + '/index.html';
 var TEST_URL3 = 'https://' + TEST_HOST + '/content.html';
 var TEST_URL4 = 'https://' + TEST_HOST + TEST_PATH + '/content.html';
 var TEST_URL5 = 'http://' + TEST_HOST + TEST_PATH + '/content.html';
 var TEST_EXPIRATION_DATE = 12345678900;
@@ skipping 189 matching lines @@
       domain: TEST_ODD_DOMAIN,
       path: TEST_ODD_PATH
     });
     chrome.cookies.get({url: TEST_ODD_URL, name: 'abcd'},
         pass(function(cookie) {
           expectValidCookie(cookie);
           chrome.test.assertEq(TEST_ODD_DOMAIN, unescape(cookie.domain));
           chrome.test.assertEq(TEST_ODD_PATH, unescape(cookie.path));
         }));
   },
+  function setCookiesWithCallbacks() {
+    removeTestCookies();
+    // Basics.
+    chrome.cookies.set(
+        TEST_BASIC_COOKIE,
+        pass(function(cookie) {
+          expectValidCookie(cookie);
+          chrome.test.assertEq(TEST_BASIC_COOKIE.name, cookie.name);
+          chrome.test.assertEq(TEST_BASIC_COOKIE.value, cookie.value);
+          chrome.test.assertEq(TEST_HOST, cookie.domain);
+          chrome.test.assertEq(true, cookie.hostOnly);
+          chrome.test.assertEq('/', cookie.path);
+          chrome.test.assertEq(false, cookie.secure);
+          chrome.test.assertEq(false, cookie.httpOnly);
+          chrome.test.assertEq(true, cookie.session);
+          chrome.test.assertTrue(typeof cookie.expirationDate === 'undefined',
+              'Session cookie should not have expirationDate property.');
+          chrome.test.assertTrue(typeof cookie.storeId !== 'undefined',
+                                 'Cookie store ID not provided.');
+        }));
+    // Invalid values generate callback with `null` cookie.
+    chrome.cookies.set(
+        {url: TEST_UNPERMITTED_URL, name: 'abcd', domain: TEST_DOMAIN},
+        fail(
+            'No host permissions for cookies at url: "'
+                + TEST_UNPERMITTED_URL + '".',
+             expectNullCookie));
+    chrome.cookies.set(
+        {url: TEST_URL, name: 'abcd=efg'},
+        fail('Failed to parse or set cookie named "abcd=efg".',
+             expectNullCookie));
+    chrome.cookies.set(
+        {url: TEST_URL, name: 'abcd', value: 'HI;LO'},
+        fail('Failed to parse or set cookie named "abcd".',
+             expectNullCookie));
+    chrome.cookies.set(
+        {url: TEST_URL, name: 'abcd', domain: 'cookies.com\r'},
+        fail('Failed to parse or set cookie named "abcd".',
+             expectNullCookie));
+    chrome.cookies.set(
+        {url: TEST_URL, name: 'abcd', domain: 'somedomain.com'},
+        fail('Failed to parse or set cookie named "abcd".',
+            expectNullCookie));
+    // Expired cookies generate callback with `null` cookie
+    chrome.cookies.set(TEST_BASIC_EXPIRED_COOKIE, pass(expectNullCookie));
+    // Odd (but valid!) URLs get callbacks too!
+    chrome.cookies.set({
+      url: TEST_ODD_URL,
+      name: 'abcd',
+      domain: TEST_ODD_DOMAIN,
+      path: TEST_ODD_PATH
+    }, pass(function(cookie) {
+      expectValidCookie(cookie);
+      chrome.test.assertEq(TEST_ODD_DOMAIN, unescape(cookie.domain));
+      chrome.test.assertEq(TEST_ODD_PATH, unescape(cookie.path));
+    }));
+
+    

[jochen (gone - plz use gerrit), 2011/02/15 13:44:10]

no empty lines

[Mike West, 2011/02/15 14:26:58]

Done.

+  },
   function removeCookie() {
     removeTestCookies();
     chrome.cookies.set(TEST_BASIC_COOKIE);
     chrome.cookies.get(
         {url: TEST_URL, name: TEST_BASIC_COOKIE.name},
         pass(expectValidCookie));
     // Removal with any domain-matching URL will do.
     chrome.cookies.remove(
         {url: TEST_URL4, name: TEST_BASIC_COOKIE.name});
     chrome.cookies.get(
@@ skipping 12 matching lines @@
     chrome.cookies.set(TEST_DOMAIN_COOKIE);
     chrome.cookies.get(
         {url: TEST_URL2, name: TEST_DOMAIN_COOKIE.name},
         pass(expectValidCookie));
     chrome.cookies.remove(
         {url: TEST_UNPERMITTED_URL, name: TEST_DOMAIN_COOKIE.name});
     chrome.cookies.get(
         {url: TEST_URL2, name: TEST_DOMAIN_COOKIE.name},
         pass(expectValidCookie));
   },
+  function removeCookiesWithCallbacks() {
+    removeTestCookies();
+    chrome.cookies.set(TEST_BASIC_COOKIE);
+    chrome.cookies.get(
+        {url: TEST_URL, name: TEST_BASIC_COOKIE.name},
+        pass(expectValidCookie));
+    // Removal with any domain-matching URL will trigger callback with the
+    // removed cookie's `url` and `name` fields.
+    chrome.cookies.remove(
+        {url: TEST_URL4, name: TEST_BASIC_COOKIE.name}, pass(function(data) {
+          chrome.test.assertEq(TEST_URL4, data.url);
+          chrome.test.assertEq(TEST_BASIC_COOKIE.name, data.name);
+        }));
+    // Removal with a disallowed URL should trigger the callback with `null`
+    chrome.cookies.set(TEST_DOMAIN_COOKIE);
+    chrome.cookies.remove(
+        {url: TEST_UNPERMITTED_URL, name: TEST_DOMAIN_COOKIE.name},
+        fail(
+            'No host permissions for cookies at url: "'
+              + TEST_UNPERMITTED_URL + '".',
+            expectNullCookie));
+  },
   function getAllCookies() {
     removeTestCookies();
     chrome.cookies.getAll({}, pass(function(cookies) {
       chrome.test.assertEq(0, cookies.length);
     }));
     chrome.cookies.set(TEST_BASIC_COOKIE);
     chrome.cookies.set(TEST_SECURE_COOKIE);
     chrome.cookies.getAll(
         {domain: TEST_DOMAIN}, pass(function(cookies) {
       chrome.test.assertEq(2, cookies.length);
@@ skipping 36 matching lines @@
           chrome.cookies.getAll(
               {storeId: cookieStores[0].id},
               pass(function(cookies) {
                 chrome.test.assertEq(1, cookies.length);
                 chrome.test.assertEq(TEST_BASIC_COOKIE.name, cookies[0].name);
               }));
         }));
   }
 ]);
 </script>