Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 6525011: start_devserver: update relative paths in command line flags (Closed)

Created:
9 years, 10 months ago by adlr
Modified:
9 years ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

start_devserver: update relative paths in command line flags Because this scripts changes directory, it's possible for relative paths to be incorrect when read by the actual dev server. This fixes the issue by prepending the current working directory to relative path args. BUG=chromium-os:12122 TEST=tested relative paths w/ dev server Change-Id: I7a85e4af5df291ec78afb0f2c1580855c38a258e Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d5e0619

Patch Set 1 #

Patch Set 2 : use realpath, handle args w/ = in them #

Patch Set 3 : remove cd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M start_devserver View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
adlr
9 years, 10 months ago (2011-02-15 03:26:03 UTC) #1
petkov
Does it make sense to use "realpath" instead? If the arg starts with "./" or ...
9 years, 10 months ago (2011-02-15 06:18:00 UTC) #2
adlr
made some fixes: use realpath, handle args w/ = in them. PTAL. thanks
9 years, 10 months ago (2011-02-16 18:06:08 UTC) #3
petkov
... still looks hacky... how about moving this logic into devserver.py? you can pass the ...
9 years, 10 months ago (2011-02-16 18:36:38 UTC) #4
adlr
I see your good cleanup suggestion and raise you one more :) Looks like the ...
9 years, 10 months ago (2011-02-16 18:54:20 UTC) #5
petkov
9 years, 10 months ago (2011-02-16 19:03:50 UTC) #6
LGTM

Nice!

Powered by Google App Engine
This is Rietveld 408576698