Add bct_dump tool.

Add bct_dump tool.

This tool dumps a human readable version of the BCT file provided on
the command line to stdout.

Change-Id: Ic9609b16aee307fd78c2d5d472d8d08072573df6

BUG=chromium-os:11981
TEST=run bct_dump on SPI and NAND BCT files and verify that the expected values are displayed.

This CL depends on: http://codereview.chromium.org/6469010/

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c624427

[robotboy, 2011-02-23 21:36:49]

Anyone want to comment on this?  Peer, are you OK with this CL?

Thanks,
    Anton

[vb, 2011-02-23 22:34:02]

a couple of nits,
otherwise LGTM,

but I suggest to hear from Nvidia folks

http://codereview.chromium.org/6524004/diff/1/GNUmakefile
File GNUmakefile (right):

http://codereview.chromium.org/6524004/diff/1/GNUmakefile#newcode22
GNUmakefile:22: $(CC) -o $@ $^ $(CFLAGS)
just out of curiosity: wouldn't

cbootimage: $(CBOOTIMAGE_C_FILES)
   $(CC) -o $@ $^ $(CFLAGS)

do the same, obviating the need to define CBOOTIMAGE_OBJS?

http://codereview.chromium.org/6524004/diff/1/bct_dump.c
File bct_dump.c (right):

http://codereview.chromium.org/6524004/diff/1/bct_dump.c#newcode101
bct_dump.c:101: &bootloaders_used,
please wrap long lines

[robotboy, 2011-02-23 22:45:52]

Comments below.

Thanks,
   Anton

http://codereview.chromium.org/6524004/diff/1/GNUmakefile
File GNUmakefile (right):

http://codereview.chromium.org/6524004/diff/1/GNUmakefile#newcode22
GNUmakefile:22: $(CC) -o $@ $^ $(CFLAGS)
On 2011/02/23 22:34:02, vb wrote:
> just out of curiosity: wouldn't
> 
> cbootimage: $(CBOOTIMAGE_C_FILES)
>    $(CC) -o $@ $^ $(CFLAGS)
> 
> do the same, obviating the need to define CBOOTIMAGE_OBJS?

It does mostly the same thing.  It makes the output of the make invocation a
little harder to parse because you only have one command line for all of C
files.  It's also not what the original makefile did and I think thats probably
the best reason to leave it be.

http://codereview.chromium.org/6524004/diff/1/bct_dump.c
File bct_dump.c (right):

http://codereview.chromium.org/6524004/diff/1/bct_dump.c#newcode101
bct_dump.c:101: &bootloaders_used,
This is an artifact of the code review server.  These files actually use 4 space
hard tab indentation.  So each tab should be rendered as 4 spaces.

[pchen, 2011-02-24 10:26:08]

looks good to me.