Issue 6523062: Cancel prerender if any of the visited URLs are https.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6523062: Cancel prerender if any of the visited URLs are https. (Closed)

Created:
9 years, 10 months ago by cbentzel

Modified:
9 years, 7 months ago

Reviewers:
mmenke, tburkard

CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Cancel prerender if any of the visited URLs are https. BUG=72486 TEST=added new unit_tests and browser_tests Manual Test: With preendering enabled, do a search for "yahoo mail". Prerendering should be canceled due to https. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75393

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1

Patch Set 3 : Rebase #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -28 lines)			Patch
M	chrome/browser/prerender/prerender_browsertest.cc	View	1 2	2 chunks	+29 lines, -4 lines	0 comments	Download
M	chrome/browser/prerender/prerender_contents.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/prerender/prerender_contents.cc	View	1 2	4 chunks	+19 lines, -8 lines	0 comments	Download
M	chrome/browser/prerender/prerender_resource_handler.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prerender/prerender_resource_handler.cc	View	1	5 chunks	+29 lines, -6 lines	0 comments	Download
M	chrome/browser/prerender/prerender_resource_handler_unittest.cc	View	1	3 chunks	+25 lines, -4 lines	0 comments	Download
M	chrome/test/data/prerender/prerender_loader.html	View		1 chunk	+1 line, -4 lines	0 comments	Download
A	chrome/test/data/prerender/prerender_redirect_to_https.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cbentzel

This is the same CL as before that I reverted. Both local tests and trybots ...

9 years, 10 months ago (2011-02-16 18:34:17 UTC) #1

mmenke

9 years, 10 months ago (2011-02-17 16:27:19 UTC) #3

LGTM

http://codereview.chromium.org/6523062/diff/10/chrome/browser/prerender/prere...
File chrome/browser/prerender/prerender_contents.h (right):

http://codereview.chromium.org/6523062/diff/10/chrome/browser/prerender/prere...
chrome/browser/prerender/prerender_contents.h:193: // the URL is valid.
nit:  Should be a little clearer, since it does not, in fact, call
GURL::is_valid().  "is valid for prerendering"?

Expand Messages | Collapse Messages