Even more test cleanup. Some fixes to non-test code.

chrome/browser/content_settings/content_settings_base_provider.cc

Index: chrome/browser/content_settings/content_settings_base_provider.cc
diff --git a/chrome/browser/content_settings/content_settings_base_provider.cc b/chrome/browser/content_settings/content_settings_base_provider.cc
index 843b50d955acbd56724bfececee48b93cc9b8c69..1cd250096873ffc34ca1ccc96d2709d70826f1b4 100644
--- a/chrome/browser/content_settings/content_settings_base_provider.cc
+++ b/chrome/browser/content_settings/content_settings_base_provider.cc
@@ -29,6 +29,22 @@ const bool kRequiresResourceIdentifier[CONTENT_SETTINGS_NUM_TYPES] = {
 
 namespace content_settings {
 
+ExtendedContentSettings::ExtendedContentSettings() {}
+
+ExtendedContentSettings::ExtendedContentSettings(
+    const ExtendedContentSettings& rhs)
+    : content_settings(rhs.content_settings),
+      content_settings_for_resources(rhs.content_settings_for_resources) {

[Nico, 2011/02/15 21:25:37]

this (can't rely on implicit copy constructors) is a bit of a bummer

[Elliot Glaysher, 2011/02/15 22:09:51]

map of string to map of pair of enum and string to arbitrary array?

We need to go deeper.

+}
+
+ExtendedContentSettings::~ExtendedContentSettings() {}
+
+BaseProvider::BaseProvider(bool is_otr)
+      : is_off_the_record_(is_otr) {

[Nico, 2011/02/15 21:25:37]

indent only 4

+}
+
+BaseProvider::~BaseProvider() {}
+
 bool BaseProvider::RequiresResourceIdentifier(
     ContentSettingsType content_type) const {
   if (CommandLine::ForCurrentProcess()->HasSwitch(