Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3620)

Unified Diff: chrome/test/webdriver/commands/webelement_commands.h

Issue 6523032: Even more test cleanup. Some fixes to non-test code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/webelement_commands.h
diff --git a/chrome/test/webdriver/commands/webelement_commands.h b/chrome/test/webdriver/commands/webelement_commands.h
index ec5d6b7c36a12ec15171f8852ec9699b499f04a3..0484742972ea3aaf7cc5a7c8b26ac22fec6a175c 100644
--- a/chrome/test/webdriver/commands/webelement_commands.h
+++ b/chrome/test/webdriver/commands/webelement_commands.h
@@ -20,11 +20,9 @@ class Response;
// service.
class WebElementCommand : public WebDriverCommand {
public:
- inline WebElementCommand(const std::vector<std::string>& path_segments,
- const DictionaryValue* const parameters)
- : WebDriverCommand(path_segments, parameters),
- path_segments_(path_segments) {}
- virtual ~WebElementCommand() {}
+ WebElementCommand(const std::vector<std::string>& path_segments,
+ const DictionaryValue* const parameters);
+ virtual ~WebElementCommand();
virtual bool Init(Response* const response);
@@ -36,7 +34,7 @@ class WebElementCommand : public WebDriverCommand {
std::string element_id;
private:
- virtual bool RequiresValidTab() { return true; }
+ virtual bool RequiresValidTab();
DISALLOW_COPY_AND_ASSIGN(WebElementCommand);
};
@@ -47,12 +45,11 @@ class WebElementCommand : public WebDriverCommand {
class ElementValueCommand : public WebElementCommand {
public:
ElementValueCommand(const std::vector<std::string>& path_segments,
- DictionaryValue* parameters)
- : WebElementCommand(path_segments, parameters) {}
- virtual ~ElementValueCommand() {}
+ DictionaryValue* parameters);
+ virtual ~ElementValueCommand();
- virtual bool DoesGet() { return true; }
- virtual bool DoesPost() { return true; }
+ virtual bool DoesGet();
+ virtual bool DoesPost();
virtual void ExecuteGet(Response* const response);
virtual void ExecutePost(Response* const response);
@@ -65,11 +62,10 @@ class ElementValueCommand : public WebElementCommand {
class ElementTextCommand : public WebElementCommand {
public:
ElementTextCommand(const std::vector<std::string>& path_segments,
- DictionaryValue* parameters)
- : WebElementCommand(path_segments, parameters) {}
- virtual ~ElementTextCommand() {}
+ DictionaryValue* parameters);
+ virtual ~ElementTextCommand();
- virtual bool DoesGet() { return true; }
+ virtual bool DoesGet();
virtual void ExecuteGet(Response* const response);
private:

Powered by Google App Engine
This is Rietveld 408576698