Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4646)

Unified Diff: chrome/test/webdriver/commands/speed_command.h

Issue 6523032: Even more test cleanup. Some fixes to non-test code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/speed_command.h
diff --git a/chrome/test/webdriver/commands/speed_command.h b/chrome/test/webdriver/commands/speed_command.h
index 7c8c7eb3f4060cb2f4d1a6f08e2f5386c16fefa3..6bd84a38111bdb7aacf38c65e37f1e8e3c78e412 100644
--- a/chrome/test/webdriver/commands/speed_command.h
+++ b/chrome/test/webdriver/commands/speed_command.h
@@ -20,20 +20,20 @@ namespace webdriver {
class SpeedCommand : public WebDriverCommand {
public:
SpeedCommand(const std::vector<std::string>& path_segments,
- const DictionaryValue* const parameters)
- : WebDriverCommand(path_segments, parameters), speed_(Session::kMedium) {}
- virtual ~SpeedCommand() {}
+ const DictionaryValue* const parameters);
+ virtual ~SpeedCommand();
virtual bool Init(Response* const response);
- virtual bool DoesGet() { return true; }
- virtual bool DoesPost() { return true; }
+ virtual bool DoesGet();
+ virtual bool DoesPost();
virtual void ExecuteGet(Response* const response);
virtual void ExecutePost(Response* const response);
private:
+ virtual bool RequiresValidTab();
+
Session::Speed speed_;
- virtual bool RequiresValidTab() { return true; }
DISALLOW_COPY_AND_ASSIGN(SpeedCommand);
};

Powered by Google App Engine
This is Rietveld 408576698