Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: chrome/test/webdriver/commands/session_with_id.h

Issue 6523032: Even more test cleanup. Some fixes to non-test code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/session_with_id.h
diff --git a/chrome/test/webdriver/commands/session_with_id.h b/chrome/test/webdriver/commands/session_with_id.h
index a85bc5f615ed624c62be95af3cee0a9563574069..80847166451585e41f5e696c648c31a310bd7f57 100644
--- a/chrome/test/webdriver/commands/session_with_id.h
+++ b/chrome/test/webdriver/commands/session_with_id.h
@@ -22,19 +22,18 @@ namespace webdriver {
// files and directories created are deleted.
class SessionWithID : public WebDriverCommand {
public:
- inline SessionWithID(const std::vector<std::string>& path_segments,
- const DictionaryValue* const parameters)
- : WebDriverCommand(path_segments, parameters) {}
- virtual ~SessionWithID() {}
+ SessionWithID(const std::vector<std::string>& path_segments,
+ const DictionaryValue* const parameters);
+ virtual ~SessionWithID();
- virtual bool DoesGet() { return true; }
- virtual bool DoesDelete() { return true; }
+ virtual bool DoesGet();
+ virtual bool DoesDelete();
virtual void ExecuteGet(Response* const response);
virtual void ExecuteDelete(Response* const response);
private:
- virtual bool RequiresValidTab() { return false; }
+ virtual bool RequiresValidTab();
DISALLOW_COPY_AND_ASSIGN(SessionWithID);
};

Powered by Google App Engine
This is Rietveld 408576698