Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/test/webdriver/commands/navigate_commands.h

Issue 6523032: Even more test cleanup. Some fixes to non-test code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/navigate_commands.h
diff --git a/chrome/test/webdriver/commands/navigate_commands.h b/chrome/test/webdriver/commands/navigate_commands.h
index a913315b02e847d7ebf39da285c87d24175e7011..754e868910690391617c0b40a7da19f7edba4c15 100644
--- a/chrome/test/webdriver/commands/navigate_commands.h
+++ b/chrome/test/webdriver/commands/navigate_commands.h
@@ -17,15 +17,14 @@ namespace webdriver {
class ForwardCommand : public WebDriverCommand {
public:
ForwardCommand(const std::vector<std::string>& path_segments,
- const DictionaryValue* const parameters)
- : WebDriverCommand(path_segments, parameters) {}
- virtual ~ForwardCommand() {}
+ const DictionaryValue* const parameters);
+ virtual ~ForwardCommand();
- virtual bool DoesPost() { return true; }
+ virtual bool DoesPost();
virtual void ExecutePost(Response* const response);
private:
- virtual bool RequiresValidTab() { return true; }
+ virtual bool RequiresValidTab();
DISALLOW_COPY_AND_ASSIGN(ForwardCommand);
};
@@ -35,15 +34,14 @@ class ForwardCommand : public WebDriverCommand {
class BackCommand : public WebDriverCommand {
public:
BackCommand(const std::vector<std::string>& path_segments,
- const DictionaryValue* const parameters)
- : WebDriverCommand(path_segments, parameters) {}
- virtual ~BackCommand() {}
+ const DictionaryValue* const parameters);
+ virtual ~BackCommand();
- virtual bool DoesPost() { return true; }
+ virtual bool DoesPost();
virtual void ExecutePost(Response* const response);
private:
- virtual bool RequiresValidTab() { return true; }
+ virtual bool RequiresValidTab();
DISALLOW_COPY_AND_ASSIGN(BackCommand);
};
@@ -53,15 +51,14 @@ class BackCommand : public WebDriverCommand {
class RefreshCommand : public WebDriverCommand {
public:
RefreshCommand(const std::vector<std::string>& path_segments,
- const DictionaryValue* const parameters)
- : WebDriverCommand(path_segments, parameters) {}
- virtual ~RefreshCommand() {}
+ const DictionaryValue* const parameters);
+ virtual ~RefreshCommand();
- virtual bool DoesPost() { return true; }
+ virtual bool DoesPost();
virtual void ExecutePost(Response* const response);
private:
- virtual bool RequiresValidTab() { return true; }
+ virtual bool RequiresValidTab();
DISALLOW_COPY_AND_ASSIGN(RefreshCommand);
};

Powered by Google App Engine
This is Rietveld 408576698