Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: chrome/test/webdriver/commands/execute_command.h

Issue 6523032: Even more test cleanup. Some fixes to non-test code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/execute_command.h
diff --git a/chrome/test/webdriver/commands/execute_command.h b/chrome/test/webdriver/commands/execute_command.h
index b431bb1835f51a51c1535cb36447e95c2d7a653c..9a578541277c6c9e1916e346e6080d9552a58499 100644
--- a/chrome/test/webdriver/commands/execute_command.h
+++ b/chrome/test/webdriver/commands/execute_command.h
@@ -21,20 +21,20 @@ namespace webdriver {
class ExecuteCommand : public WebDriverCommand {
public:
ExecuteCommand(const std::vector<std::string>& path_segments,
- const DictionaryValue* const parameters)
- : WebDriverCommand(path_segments, parameters) {}
- virtual ~ExecuteCommand() {}
+ const DictionaryValue* const parameters);
+ virtual ~ExecuteCommand();
virtual bool Init(Response* const response);
- virtual bool DoesPost() { return true; }
+ virtual bool DoesPost();
virtual void ExecutePost(Response* const response);
private:
+ virtual bool RequiresValidTab();
+
std::string script_;
bool has_args_;
std::string args_;
- virtual bool RequiresValidTab() { return true; }
DISALLOW_COPY_AND_ASSIGN(ExecuteCommand);
};

Powered by Google App Engine
This is Rietveld 408576698