Even more test cleanup. Some fixes to non-test code.

chrome/test/webdriver/commands/webelement_commands.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/webdriver/commands/webelement_commands.h"
 
 #include "base/scoped_ptr.h"
 #include "base/third_party/icu/icu_utf.h"
 #include "base/values.h"
 #include "chrome/test/webdriver/commands/response.h"
 #include "chrome/test/webdriver/error_codes.h"
 #include "chrome/test/webdriver/session.h"
 #include "chrome/test/webdriver/utility_functions.h"
 #include "third_party/webdriver/atoms.h"
 
 namespace webdriver {
 
+WebElementCommand::WebElementCommand(
+    const std::vector<std::string>& path_segments,
+    const DictionaryValue* const parameters)
+    : WebDriverCommand(path_segments, parameters),
+      path_segments_(path_segments) {}
+
+WebElementCommand::~WebElementCommand() {}
+
 bool WebElementCommand::Init(Response* const response) {
   if (!WebDriverCommand::Init(response))
     return false;
 
   // There should be at least 5 segments to match
   // "/session/$session/element/$id"
   if (path_segments_.size() < 5) {
     SET_WEBDRIVER_ERROR(response, "Path segments is less than 5",
                         kBadRequest);
     return false;
@@ skipping 49 matching lines @@
     LOG(ERROR) << "Expected JavaScript atom to return "
                << "{width:number, height:number} dictionary." << std::endl;
     return false;
   }
 
   DictionaryValue* dict = static_cast<DictionaryValue*>(result);
   return dict->GetInteger("width", width) &&
          dict->GetInteger("height", height);
 }
 
+bool WebElementCommand::RequiresValidTab() {
+  return true;
+}
+
+ElementValueCommand::ElementValueCommand(
+    const std::vector<std::string>& path_segments,
+    DictionaryValue* parameters)
+    : WebElementCommand(path_segments, parameters) {}
+
+ElementValueCommand::~ElementValueCommand() {}
+
+bool ElementValueCommand::DoesGet() {
+  return true;
+}
+
+bool ElementValueCommand::DoesPost() {
+  return true;
+}
+
 void ElementValueCommand::ExecuteGet(Response* const response) {
   Value* unscoped_result = NULL;
   ListValue args;
   std::string script = "return arguments[0]['value']";
   args.Append(GetElementIdAsDictionaryValue(element_id));
   ErrorCode code =
       session_->ExecuteScript(script, &args, &unscoped_result);
   scoped_ptr<Value> result(unscoped_result);
   if (code != kSuccess) {
     SET_WEBDRIVER_ERROR(response, "Failed to execute script", code);
@@ skipping 39 matching lines @@
       session_->SendKeys(GetElementIdAsDictionaryValue(element_id), keys);
   if (code != kSuccess) {
     SET_WEBDRIVER_ERROR(response,
                         "Internal SendKeys error",
                         code);
     return;
   }
   response->set_status(kSuccess);
 }
 
+ElementTextCommand::ElementTextCommand(
+    const std::vector<std::string>& path_segments,
+    DictionaryValue* parameters)
+    : WebElementCommand(path_segments, parameters) {}
+
+ElementTextCommand::~ElementTextCommand() {}
+
+bool ElementTextCommand::DoesGet() {
+  return true;
+}
+
 void ElementTextCommand::ExecuteGet(Response* const response) {
   Value* unscoped_result = NULL;
   ListValue args;
   // TODO(jleyba): Use a real javascript atom.
   std::string script =
       "function getText(element) {"
       "  if (element instanceof Text) {"
       "    return element.textContent.replace(/^\\s+|\\s+$/g, '');"
       "  }"
       "  var childrenText = '';"
@@ skipping 15 matching lines @@
     SET_WEBDRIVER_ERROR(response,
                         "Result is not string type",
                         kInternalServerError);
     return;
   }
   response->set_status(kSuccess);
   response->set_value(result.release());
 }
 
 }  // namespace webdriver